Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Custom Params #647

Closed
nynymike opened this issue Sep 18, 2017 · 5 comments
Closed

Support Custom Params #647

nynymike opened this issue Sep 18, 2017 · 5 comments
Assignees
Labels
enhancement libs update, re-factroring, etc. high priority resolution must be prioritized
Milestone

Comments

@nynymike
Copy link
Contributor

http://openid.net/specs/openid-connect-core-1_0.html#AuthRequest

Other parameters MAY be sent.

Using the state param is useful where the client can't use additional params (like AppAuth). But sending additional params is cleaner in many cases.

@nynymike nynymike added the enhancement libs update, re-factroring, etc. label Sep 18, 2017
@nynymike nynymike added this to the CE 3.1.1 milestone Sep 18, 2017
@rajnikantsh
Copy link
Contributor

code comitted. created pull request #656

@yurem yurem modified the milestones: CE 3.1.1, CE 3.1.2 Oct 9, 2017
@nynymike nynymike added the high priority resolution must be prioritized label Nov 3, 2017
@nynymike
Copy link
Contributor Author

nynymike commented Nov 3, 2017

I don't know why RK messed with the state. If a client wants to encode a value in the state, that's a different solution. In my request, I was saying that in the /authorize request, a client can add params not specified in the openid connect standard. for example:

/authorize?client_id=1111@redirect_uri=...&unicorn=pink

Now OpenID Connect doesn't define the unicorn parameter, so it's ok.

@nynymike
Copy link
Contributor Author

Javier, I'm assigning this to you only.

@yurem
Copy link
Contributor

yurem commented Nov 13, 2017

To make this part more controlled we can add new configuration list property to specify list of accepted custom parameters like unicorn

@qbert2k
Copy link
Contributor

qbert2k commented Nov 24, 2017

  1. There is a new entry in oxAuth configuration to add custom parameters, for example:
    "authorizationRequestCustomAllowedParameters" : [
        "customParam1",
        "customParam2",
        "customParam3"
    ]

2 . There is a test showing how to send custom param at org.xdi.oxauth.ws.rs.AuthorizationSupportCustomParams

        authorizationRequest.addCustomParameter("customParam1", "value1");
        authorizationRequest.addCustomParameter("customParam2", "value2");
        authorizationRequest.addCustomParameter("customParam3", "value3");
  1. The custom parameters are available to use by custom python scripts and can be read from the session, see attached image.

screen shot 2017-11-23 at 10 06 41 pm

qbert2k added a commit that referenced this issue Nov 24, 2017
Support Custom Params
qbert2k added a commit that referenced this issue Nov 24, 2017
Support Custom Params
@qbert2k qbert2k closed this as completed Nov 24, 2017
qbert2k added a commit that referenced this issue Nov 25, 2017
Prevent NPE when queryString is null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement libs update, re-factroring, etc. high priority resolution must be prioritized
Projects
None yet
Development

No branches or pull requests

4 participants