Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for inlined source in input source maps. #397

Closed
jakubpawlowicz opened this issue Dec 6, 2014 · 5 comments
Closed

Add support for inlined source in input source maps. #397

jakubpawlowicz opened this issue Dec 6, 2014 · 5 comments
Assignees
@jakubpawlowicz
Labels
enhancement
Milestone
3.2

Comments

@jakubpawlowicz
Copy link
Collaborator

See #125 (comment)
@jakubpawlowicz jakubpawlowicz self-assigned this Dec 6, 2014
@jakubpawlowicz jakubpawlowicz added this to the 3.1 milestone Dec 6, 2014
@jakubpawlowicz jakubpawlowicz mentioned this issue Dec 7, 2014
Closed
@jakubpawlowicz jakubpawlowicz modified the milestones: 3.2, 3.1 Jan 6, 2015
@boogerlad
Copy link

Any updates?

@jakubpawlowicz
Copy link
Collaborator Author

Scheduled for 3.2. Nothing more so far!

@adamburgess adamburgess mentioned this issue Mar 7, 2015
Closed
jakubpawlowicz added a commit that referenced this issue Mar 15, 2015
@jakubpawlowicz
Fixes #397 - support for source map's sourcesContent property.
50cdd63 
When handling input source map it checks whether sourcesContent is present
and if it is so then it's reused in the output source map.

 Please enter the commit message for your changes. Lines starting
jakubpawlowicz added a commit that referenced this issue Mar 16, 2015
@jakubpawlowicz
Fixes #397 - support for source map's sourcesContent property.
d2f79c9 
When handling input source map it checks whether sourcesContent is present
and if it is so then it's reused in the output source map.

Adds `sourceMapInlineSources` / `--source-map-inline-source` switches to
control whether an inlined source map is created or not.

In case an input source map with a `sourcesContent` field is provided
then all sources from that source map are carried over to the output source map.
jakubpawlowicz added a commit that referenced this issue Mar 16, 2015
@jakubpawlowicz
Fixes #397 - support for source map's sourcesContent property.
5393ed9 
When handling input source map it checks whether sourcesContent is present
and if it is so then it's reused in the output source map.

Adds `sourceMapInlineSources` / `--source-map-inline-source` switches to
control whether an inlined source map is created or not.

In case an input source map with a `sourcesContent` field is provided
then all sources from that source map are carried over to the output source map.
@jakubpawlowicz
Copy link
Collaborator Author

@boogerlad @lukeapage implemented in master, to be released with 3.2.

@thealjey
Copy link

thealjey commented Apr 8, 2015

@jakubpawlowicz this is a much anticipated feature, the lack of which though is not big enough an issue as to make the whole library unusable (if it were a javascript minifier, for example, it would be), but it would still be great to have it.
Any idea on when 3.2 will be released?
Also, I got a little confused by the "sourceMapInlineSources" option name (maybe it's just me), it'd be nice if the documentation mentioned that that particular config option is for the "sourcesContent" key of the source map.
Thanks!

@jakubpawlowicz
Copy link
Collaborator Author

@thealjey I plan to do it within next week. You can always use the 3.2.0-pre master if possible as the code for sourcesContent won't change.

Re naming I just followed the way Less.js calls this switch, but I'll clarify it in the readme too.

jakubpawlowicz added a commit that referenced this issue Apr 11, 2015
@jakubpawlowicz
Clarifies where --source-map-inline-sources output goes.
0eb1a17 
See #397 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakubpawlowicz jakubpawlowicz

Labels
enhancement
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
3 participants
@jakubpawlowicz @boogerlad @thealjey