From 41b8dcc07b51c882b37c9edf52073ea76f75c9bd Mon Sep 17 00:00:00 2001 From: Matthew Thompson Date: Tue, 15 Nov 2022 14:02:43 -0500 Subject: [PATCH 1/2] Fixes #18. Guard against default install prefix --- CMakeLists.txt | 10 ++++++++++ ChangeLog.md | 7 +++++++ 2 files changed, 17 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5354e9d..b70dd1a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -5,6 +5,16 @@ project (GFE ) cmake_policy(SET CMP0074 NEW) +# Most users of this software do not (should not?) have permissions to +# install in the cmake default of /usr/local (or equiv on other os's). +# Below, the default is changed to a directory within the build tree +# unless the user explicitly sets CMAKE_INSTALL_PREFIX in the cache. +if (CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT) + set (CMAKE_INSTALL_PREFIX "${CMAKE_BINARY_DIR}/installed" CACHE PATH "default install path" FORCE ) + message(STATUS "*** Setting default install prefix to ${CMAKE_INSTALL_PREFIX}.") + message(STATUS "*** Override with -DCMAKE_INSTALL_PREFIX=.") +endif() + enable_testing() add_subdirectory(gFTL) diff --git a/ChangeLog.md b/ChangeLog.md index e4ddc84..933413f 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -5,6 +5,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [1.8.0] - 2022-11-15 + +### Changed + +- Change behavior if user does not pass in `CMAKE_INSTALL_PREFIX` to put install directory inside build (as we are know we can + write there; default for CMake install is `/usr/local`) + ## [1.7.0] - 2022-11-15 ### Changed From fc2d6e1828ff75b06e296ecbd470ea98235f4ee1 Mon Sep 17 00:00:00 2001 From: Matthew Thompson Date: Tue, 15 Nov 2022 14:59:19 -0500 Subject: [PATCH 2/2] Add codeowners --- .github/CODEOWNERS | 1 + ChangeLog.md | 4 ++++ 2 files changed, 5 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000..8e766a3 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1 @@ +* @tclune diff --git a/ChangeLog.md b/ChangeLog.md index 933413f..4cc10cd 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Change behavior if user does not pass in `CMAKE_INSTALL_PREFIX` to put install directory inside build (as we are know we can write there; default for CMake install is `/usr/local`) + +### Added + +- Added `CODEOWNERS` file ## [1.7.0] - 2022-11-15