Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Blobfish's Edits (Workshop Support) #106

Closed
ithinkandicode opened this issue Feb 11, 2023 · 3 comments · Fixed by #148
Closed

Implement Blobfish's Edits (Workshop Support) #106

ithinkandicode opened this issue Feb 11, 2023 · 3 comments · Fixed by #148
Assignees
@ithinkandicode
Labels
enhancement New feature or request
Milestone
3.x - v6.0.0

Comments

@ithinkandicode
Copy link
Collaborator

Brotato uses a custom version of ModLoader that has support for loading from Steam Workshop folders.

We should implement their work, so that Brotato can be updated to use the latest version of ModLoader without needing custom edits.

The modified version of ModLoader is attached, decompiled from the current Brotato PCK (v0.8.0.0-beta). It's based on version 4.1.

ModLoader-v4.1--Blobfish-Edit.zip
@ithinkandicode ithinkandicode changed the title Implement Blobfish's Edits Implement Blobfish's Edits (Workshop Support) Feb 11, 2023
@ithinkandicode ithinkandicode added the enhancement New feature or request label Feb 11, 2023
@ithinkandicode
Copy link
Collaborator Author

I have also made a set of files for easy comparison, see this ZIP:

ModLoader-Version-Compare.zip

If you have a diff app, compare these folders. Comments were removed because the decompiler also strips them.

  • BEFORE: mod_loader--4.1-nocomments+fixes
  • AFTER: mod_loader--brotato

I've also made a diff report HTML, so you can see the results immediately:

ModLoader-Diff.zip

@ithinkandicode
Copy link
Collaborator Author

When we do this, it'd be cool to get the disabling stuff sorted too for the same major release, as that was specifically requested by Brotato players:

@ithinkandicode ithinkandicode added this to the Brotato Update milestone Feb 26, 2023
@ithinkandicode ithinkandicode mentioned this issue Feb 27, 2023
Closed
@ithinkandicode ithinkandicode self-assigned this Feb 27, 2023
@ithinkandicode ithinkandicode mentioned this issue Feb 27, 2023
Merged
@ithinkandicode ithinkandicode linked a pull request Feb 27, 2023 that will close this issue
feat: ✨ Workshop Support #148
Merged
@ithinkandicode
Copy link
Collaborator Author

Closed by #148 🤘

@ithinkandicode ithinkandicode modified the milestones: Brotato Update, v6.0.0 Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ithinkandicode ithinkandicode

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.x - v6.0.0
Development

Successfully merging a pull request may close this issue.

feat: ✨ Workshop Support ithinkandicode/godot-mod-loader
1 participant
@ithinkandicode