Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ♻️ new create mod popup #59

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Conversation

KANAjetzt
Copy link
Member

@KANAjetzt KANAjetzt commented Jul 5, 2023

  • Separate inputs for namespace and modname.
  • Added a preview read-only input for the mod_id.
  • Included template selection in the create mod popup and removed it from the main panel.
  • Fixed the issue with the "value_changed" signal for ModToolInterfaceInputOptions that was not connected to the method, and modified it to send the string value.

image

depends on #57
depends on #58
closes #49

@KANAjetzt KANAjetzt added enhancement New feature or request refactor / cleanup labels Jul 5, 2023
@KANAjetzt KANAjetzt added this to the v0.1.0 milestone Jul 5, 2023
@KANAjetzt KANAjetzt requested a review from Qubus0 July 5, 2023 08:51
@KANAjetzt KANAjetzt self-assigned this Jul 5, 2023
- Separate inputs for namespace and modname. - Added a preview read-only input for the mod_id. - Included template selection in the create mod popup and removed it from the main panel. - Fixed the issue with the `"value_changed"` signal for `ModToolInterfaceInputOptions` that was not connected to the method, and modified it to send the string value.

closes #49
@KANAjetzt KANAjetzt force-pushed the refactor_create_mod branch from 1d90e2d to eb2ffea Compare July 5, 2023 09:04
addons/mod_tool/interface/panel/tools_panel.tscn Outdated Show resolved Hide resolved
@KANAjetzt KANAjetzt added this pull request to the merge queue Jul 5, 2023
Merged via the queue into main with commit 2bd98c3 Jul 5, 2023
@KANAjetzt KANAjetzt deleted the refactor_create_mod branch July 5, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor / cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Create Mod Popup
2 participants