Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NetworkTables Singleton #42

Merged
merged 42 commits into from
Jul 19, 2024
Merged

Remove NetworkTables Singleton #42

merged 42 commits into from
Jul 19, 2024

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented May 18, 2024

  • Pass in an NT instance to every widget requiring Network Tables data
  • Improve test coverage

Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 74.35233% with 198 lines in your changes missing coverage. Please review.

Project coverage is 61.53%. Comparing base (beb5b24) to head (c598093).

Files Patch % Lines
lib/pages/dashboard_page.dart 48.19% 86 Missing ⚠️
lib/services/shuffleboard_nt_listener.dart 43.13% 29 Missing ⚠️
lib/services/nt_connection.dart 63.15% 14 Missing ⚠️
lib/widgets/tab_grid.dart 83.90% 14 Missing ⚠️
lib/main.dart 30.76% 9 Missing ⚠️
...b/widgets/network_tree/networktables_tree_row.dart 50.00% 7 Missing ⚠️
...aggable_containers/draggable_widget_container.dart 57.14% 6 Missing ⚠️
...e_containers/models/nt_widget_container_model.dart 50.00% 5 Missing ⚠️
lib/services/nt4_client.dart 73.33% 4 Missing ⚠️
...able_containers/models/widget_container_model.dart 60.00% 4 Missing ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #42       +/-   ##
===========================================
+ Coverage   45.99%   61.53%   +15.54%     
===========================================
  Files          74       75        +1     
  Lines        7595     7774      +179     
===========================================
+ Hits         3493     4784     +1291     
+ Misses       4102     2990     -1112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gold872 added 21 commits May 18, 2024 17:28
* Split button chooser
* Subsystem
* Three axis accelerometer
* Ultrasonic
* YAGSL swerve drive
* Number Bar
* Number Slider
* Multi Color View
* Radial Gauge
* Single Color View
@Gold872 Gold872 marked this pull request as ready for review July 12, 2024 20:28
@Gold872 Gold872 merged commit 153046f into main Jul 19, 2024
5 checks passed
@Gold872 Gold872 deleted the nt-dependency-rework branch July 19, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants