Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync wipes NEO fields #19

Closed
sidneywidmer opened this issue Aug 10, 2020 · 3 comments
Closed

Sync wipes NEO fields #19

sidneywidmer opened this issue Aug 10, 2020 · 3 comments

Comments

@sidneywidmer
Copy link
Contributor

Currently the sync just wipes the target entrys field content if it's a neo field. I don't know exactly why yet, but there seems to be something changed in neo or craft how things get saved.

The $entry attached to the event seems to just have an empty array for all neo fields (other fields work just fine).

Can someone confirm this issue? I'm running Craft 3.5.1 and Neo 2.8.2

@sidneywidmer
Copy link
Contributor Author

PR with a possible fix: #20

Refetching the entry from the DB seems to solve the issue.

@christianruhstaller
Copy link
Member

We can confirm this. It seems that following commit removed the behavior for saveModifiedBlocksOnly:

spicywebau/craft-neo@ec93b31#diff-f9f066bd830d34ac463fd2a0e5f72913

Beforehand the feature was disabled:
spicywebau/craft-neo@dda1573

In the settings the option is still available but currently unused. We'll report this to the devs of Neo.

@lukasNo1
Copy link
Member

It works correctly on all use-cases.

I merged it in the new release 0.5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants