From 0aeae73f817bfe314e010dafe6444a9285eba33c Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Wed, 17 Apr 2024 22:17:45 -0700 Subject: [PATCH] reword --- .../accessibility/aria-conditional-attr.js | 7 ++--- .../accessibility/aria-deprecated-role.js | 2 +- .../accessibility/aria-prohibited-attr.js | 7 ++--- .../reports/sample-flow-result.json | 30 +++++++++---------- core/test/results/sample_v2.json | 10 +++---- shared/localization/locales/en-US.json | 12 ++++---- shared/localization/locales/en-XL.json | 12 ++++---- 7 files changed, 39 insertions(+), 41 deletions(-) diff --git a/core/audits/accessibility/aria-conditional-attr.js b/core/audits/accessibility/aria-conditional-attr.js index 2f38a17b8095..3eca08d669f8 100644 --- a/core/audits/accessibility/aria-conditional-attr.js +++ b/core/audits/accessibility/aria-conditional-attr.js @@ -14,12 +14,11 @@ import * as i18n from '../../lib/i18n/i18n.js'; const UIStrings = { /** Title of an accessibility audit that checks if ARIA attributes are used as specified for element roles. This title is descriptive of the successful state and is shown to users when no user action is required. */ - title: 'ARIA attributes are used as specified for element roles', + title: 'ARIA attributes are used as specified for the element\'s role', /** Title of an accessibility audit that checks if ARIA attributes are used as specified for element roles. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ - failureTitle: 'ARIA attributes are not used as specified for element roles', + failureTitle: 'ARIA attributes are not used as specified for the element\'s role', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'Using ARIA attributes on elements where they are not expected can result in ' + - 'unpredictable behavior for assistive technologies. ' + + description: 'Some ARIA attributes are only allowed on an element under certain conditions. ' + '[Learn more about conditional ARIA attributes](https://dequeuniversity.com/rules/axe/4.9/aria-conditional-attr).', }; diff --git a/core/audits/accessibility/aria-deprecated-role.js b/core/audits/accessibility/aria-deprecated-role.js index 539a5d9d8889..fc1d5e3cfffd 100644 --- a/core/audits/accessibility/aria-deprecated-role.js +++ b/core/audits/accessibility/aria-deprecated-role.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accessibility audit that checks if deprecated ARIA roles are used. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'Deprecated ARIA roles were used', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'Deprecated ARIA roles will not be processed correctly by screen readers. ' + + description: 'Deprecated ARIA roles may not be processed correctly by assistive technology. ' + '[Learn more about deprecated ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-deprecated-role).', }; diff --git a/core/audits/accessibility/aria-prohibited-attr.js b/core/audits/accessibility/aria-prohibited-attr.js index c910fdcc1ab4..f4f56114b1e1 100644 --- a/core/audits/accessibility/aria-prohibited-attr.js +++ b/core/audits/accessibility/aria-prohibited-attr.js @@ -14,13 +14,12 @@ import * as i18n from '../../lib/i18n/i18n.js'; const UIStrings = { /** Title of an accessibility audit that checks if elements use prohibited ARIA attributes. This title is descriptive of the successful state and is shown to users when no user action is required. */ - title: 'Elements only use permitted ARIA attributes', + title: 'Elements use only permitted ARIA attributes', /** Title of an accessibility audit that checks if elements use prohibited ARIA attributes. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'Elements use prohibited ARIA attributes', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'Element roles can prohibit certain ARIA attributes from being used ' + - 'on that element. Using one of these prohibited roles can lead to undefined behavior by ' + - 'assistive technology. ' + + description: 'Using ARIA attributes in roles where they are prohibited can mean that important ' + + 'information is not communicated to users of assistive technologies. ' + '[Learn more about prohibited ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-prohibited-attr).', }; diff --git a/core/test/fixtures/user-flows/reports/sample-flow-result.json b/core/test/fixtures/user-flows/reports/sample-flow-result.json index f63f73acde1b..e2dd0c8a674a 100644 --- a/core/test/fixtures/user-flows/reports/sample-flow-result.json +++ b/core/test/fixtures/user-flows/reports/sample-flow-result.json @@ -2052,8 +2052,8 @@ }, "aria-conditional-attr": { "id": "aria-conditional-attr", - "title": "ARIA attributes are used as specified for element roles", - "description": "Using ARIA attributes on elements where they are not expected can result in unpredictable behavior for assistive technologies. [Learn more about conditional ARIA attributes](https://dequeuniversity.com/rules/axe/4.9/aria-conditional-attr).", + "title": "ARIA attributes are used as specified for the element's role", + "description": "Some ARIA attributes are only allowed on an element under certain conditions. [Learn more about conditional ARIA attributes](https://dequeuniversity.com/rules/axe/4.9/aria-conditional-attr).", "score": 1, "scoreDisplayMode": "binary", "details": { @@ -2065,7 +2065,7 @@ "aria-deprecated-role": { "id": "aria-deprecated-role", "title": "Deprecated ARIA roles were not used", - "description": "Deprecated ARIA roles will not be processed correctly by screen readers. [Learn more about deprecated ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-deprecated-role).", + "description": "Deprecated ARIA roles may not be processed correctly by assistive technology. [Learn more about deprecated ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-deprecated-role).", "score": 1, "scoreDisplayMode": "binary", "details": { @@ -2133,8 +2133,8 @@ }, "aria-prohibited-attr": { "id": "aria-prohibited-attr", - "title": "Elements only use permitted ARIA attributes", - "description": "Element roles can prohibit certain ARIA attributes from being used on that element. Using one of these prohibited roles can lead to undefined behavior by assistive technology. [Learn more about prohibited ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-prohibited-attr).", + "title": "Elements use only permitted ARIA attributes", + "description": "Using ARIA attributes in roles where they are prohibited can mean that important information is not communicated to users of assistive technologies. [Learn more about prohibited ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-prohibited-attr).", "score": 1, "scoreDisplayMode": "binary", "details": { @@ -12395,8 +12395,8 @@ }, "aria-conditional-attr": { "id": "aria-conditional-attr", - "title": "ARIA attributes are used as specified for element roles", - "description": "Using ARIA attributes on elements where they are not expected can result in unpredictable behavior for assistive technologies. [Learn more about conditional ARIA attributes](https://dequeuniversity.com/rules/axe/4.9/aria-conditional-attr).", + "title": "ARIA attributes are used as specified for the element's role", + "description": "Some ARIA attributes are only allowed on an element under certain conditions. [Learn more about conditional ARIA attributes](https://dequeuniversity.com/rules/axe/4.9/aria-conditional-attr).", "score": 1, "scoreDisplayMode": "binary", "details": { @@ -12408,7 +12408,7 @@ "aria-deprecated-role": { "id": "aria-deprecated-role", "title": "Deprecated ARIA roles were not used", - "description": "Deprecated ARIA roles will not be processed correctly by screen readers. [Learn more about deprecated ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-deprecated-role).", + "description": "Deprecated ARIA roles may not be processed correctly by assistive technology. [Learn more about deprecated ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-deprecated-role).", "score": 1, "scoreDisplayMode": "binary", "details": { @@ -12476,8 +12476,8 @@ }, "aria-prohibited-attr": { "id": "aria-prohibited-attr", - "title": "Elements only use permitted ARIA attributes", - "description": "Element roles can prohibit certain ARIA attributes from being used on that element. Using one of these prohibited roles can lead to undefined behavior by assistive technology. [Learn more about prohibited ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-prohibited-attr).", + "title": "Elements use only permitted ARIA attributes", + "description": "Using ARIA attributes in roles where they are prohibited can mean that important information is not communicated to users of assistive technologies. [Learn more about prohibited ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-prohibited-attr).", "score": 1, "scoreDisplayMode": "binary", "details": { @@ -19237,8 +19237,8 @@ }, "aria-conditional-attr": { "id": "aria-conditional-attr", - "title": "ARIA attributes are used as specified for element roles", - "description": "Using ARIA attributes on elements where they are not expected can result in unpredictable behavior for assistive technologies. [Learn more about conditional ARIA attributes](https://dequeuniversity.com/rules/axe/4.9/aria-conditional-attr).", + "title": "ARIA attributes are used as specified for the element's role", + "description": "Some ARIA attributes are only allowed on an element under certain conditions. [Learn more about conditional ARIA attributes](https://dequeuniversity.com/rules/axe/4.9/aria-conditional-attr).", "score": 1, "scoreDisplayMode": "binary", "details": { @@ -19250,7 +19250,7 @@ "aria-deprecated-role": { "id": "aria-deprecated-role", "title": "Deprecated ARIA roles were not used", - "description": "Deprecated ARIA roles will not be processed correctly by screen readers. [Learn more about deprecated ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-deprecated-role).", + "description": "Deprecated ARIA roles may not be processed correctly by assistive technology. [Learn more about deprecated ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-deprecated-role).", "score": 1, "scoreDisplayMode": "binary", "details": { @@ -19318,8 +19318,8 @@ }, "aria-prohibited-attr": { "id": "aria-prohibited-attr", - "title": "Elements only use permitted ARIA attributes", - "description": "Element roles can prohibit certain ARIA attributes from being used on that element. Using one of these prohibited roles can lead to undefined behavior by assistive technology. [Learn more about prohibited ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-prohibited-attr).", + "title": "Elements use only permitted ARIA attributes", + "description": "Using ARIA attributes in roles where they are prohibited can mean that important information is not communicated to users of assistive technologies. [Learn more about prohibited ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-prohibited-attr).", "score": 1, "scoreDisplayMode": "binary", "details": { diff --git a/core/test/results/sample_v2.json b/core/test/results/sample_v2.json index c27109977105..2e182bc18884 100644 --- a/core/test/results/sample_v2.json +++ b/core/test/results/sample_v2.json @@ -2827,8 +2827,8 @@ }, "aria-conditional-attr": { "id": "aria-conditional-attr", - "title": "ARIA attributes are used as specified for element roles", - "description": "Using ARIA attributes on elements where they are not expected can result in unpredictable behavior for assistive technologies. [Learn more about conditional ARIA attributes](https://dequeuniversity.com/rules/axe/4.9/aria-conditional-attr).", + "title": "ARIA attributes are used as specified for the element's role", + "description": "Some ARIA attributes are only allowed on an element under certain conditions. [Learn more about conditional ARIA attributes](https://dequeuniversity.com/rules/axe/4.9/aria-conditional-attr).", "score": 1, "scoreDisplayMode": "binary", "details": { @@ -2840,7 +2840,7 @@ "aria-deprecated-role": { "id": "aria-deprecated-role", "title": "Deprecated ARIA roles were not used", - "description": "Deprecated ARIA roles will not be processed correctly by screen readers. [Learn more about deprecated ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-deprecated-role).", + "description": "Deprecated ARIA roles may not be processed correctly by assistive technology. [Learn more about deprecated ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-deprecated-role).", "score": 1, "scoreDisplayMode": "binary", "details": { @@ -2903,8 +2903,8 @@ }, "aria-prohibited-attr": { "id": "aria-prohibited-attr", - "title": "Elements only use permitted ARIA attributes", - "description": "Element roles can prohibit certain ARIA attributes from being used on that element. Using one of these prohibited roles can lead to undefined behavior by assistive technology. [Learn more about prohibited ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-prohibited-attr).", + "title": "Elements use only permitted ARIA attributes", + "description": "Using ARIA attributes in roles where they are prohibited can mean that important information is not communicated to users of assistive technologies. [Learn more about prohibited ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-prohibited-attr).", "score": 1, "scoreDisplayMode": "binary", "details": { diff --git a/shared/localization/locales/en-US.json b/shared/localization/locales/en-US.json index 33cd74e73a29..c42a166a6ac6 100644 --- a/shared/localization/locales/en-US.json +++ b/shared/localization/locales/en-US.json @@ -36,16 +36,16 @@ "message": "`button`, `link`, and `menuitem` elements have accessible names" }, "core/audits/accessibility/aria-conditional-attr.js | description": { - "message": "Using ARIA attributes on elements where they are not expected can result in unpredictable behavior for assistive technologies. [Learn more about conditional ARIA attributes](https://dequeuniversity.com/rules/axe/4.9/aria-conditional-attr)." + "message": "Some ARIA attributes are only allowed on an element under certain conditions. [Learn more about conditional ARIA attributes](https://dequeuniversity.com/rules/axe/4.9/aria-conditional-attr)." }, "core/audits/accessibility/aria-conditional-attr.js | failureTitle": { - "message": "ARIA attributes are not used as specified for element roles" + "message": "ARIA attributes are not used as specified for the element's role" }, "core/audits/accessibility/aria-conditional-attr.js | title": { - "message": "ARIA attributes are used as specified for element roles" + "message": "ARIA attributes are used as specified for the element's role" }, "core/audits/accessibility/aria-deprecated-role.js | description": { - "message": "Deprecated ARIA roles will not be processed correctly by screen readers. [Learn more about deprecated ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-deprecated-role)." + "message": "Deprecated ARIA roles may not be processed correctly by assistive technology. [Learn more about deprecated ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-deprecated-role)." }, "core/audits/accessibility/aria-deprecated-role.js | failureTitle": { "message": "Deprecated ARIA roles were used" @@ -108,13 +108,13 @@ "message": "ARIA `progressbar` elements have accessible names" }, "core/audits/accessibility/aria-prohibited-attr.js | description": { - "message": "Element roles can prohibit certain ARIA attributes from being used on that element. Using one of these prohibited roles can lead to undefined behavior by assistive technology. [Learn more about prohibited ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-prohibited-attr)." + "message": "Using ARIA attributes in roles where they are prohibited can mean that important information is not communicated to users of assistive technologies. [Learn more about prohibited ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-prohibited-attr)." }, "core/audits/accessibility/aria-prohibited-attr.js | failureTitle": { "message": "Elements use prohibited ARIA attributes" }, "core/audits/accessibility/aria-prohibited-attr.js | title": { - "message": "Elements only use permitted ARIA attributes" + "message": "Elements use only permitted ARIA attributes" }, "core/audits/accessibility/aria-required-attr.js | description": { "message": "Some ARIA roles have required attributes that describe the state of the element to screen readers. [Learn more about roles and required attributes](https://dequeuniversity.com/rules/axe/4.9/aria-required-attr)." diff --git a/shared/localization/locales/en-XL.json b/shared/localization/locales/en-XL.json index b598c153c5a4..44fdf6acdc9f 100644 --- a/shared/localization/locales/en-XL.json +++ b/shared/localization/locales/en-XL.json @@ -36,16 +36,16 @@ "message": "`button`, `link`, âńd̂ `menuitem` él̂ém̂én̂t́ŝ h́âv́ê áĉćêśŝíb̂ĺê ńâḿêś" }, "core/audits/accessibility/aria-conditional-attr.js | description": { - "message": "Ûśîńĝ ÁR̂ÍÂ át̂t́r̂íb̂út̂éŝ ón̂ él̂ém̂én̂t́ŝ ẃĥér̂é t̂h́êý âŕê ńôt́ êx́p̂éĉt́êd́ ĉán̂ ŕêśûĺt̂ ín̂ ún̂ṕr̂éd̂íĉt́âb́l̂é b̂éĥáv̂íôŕ f̂ór̂ áŝśîśt̂ív̂é t̂éĉh́n̂ól̂óĝíêś. [L̂éâŕn̂ ḿôŕê áb̂óût́ ĉón̂d́ît́îón̂ál̂ ÁR̂ÍÂ át̂t́r̂íb̂út̂éŝ](https://dequeuniversity.com/rules/axe/4.9/aria-conditional-attr)." + "message": "Ŝóm̂é ÂŔÎÁ ât́t̂ŕîb́ût́êś âŕê ón̂ĺŷ ál̂ĺôẃêd́ ôń âń êĺêḿêńt̂ ún̂d́êŕ ĉér̂t́âín̂ ćôńd̂ít̂íôńŝ. [Ĺêár̂ń m̂ór̂é âb́ôút̂ ćôńd̂ít̂íôńâĺ ÂŔÎÁ ât́t̂ŕîb́ût́êś](https://dequeuniversity.com/rules/axe/4.9/aria-conditional-attr)." }, "core/audits/accessibility/aria-conditional-attr.js | failureTitle": { - "message": "ÂŔÎÁ ât́t̂ŕîb́ût́êś âŕê ńôt́ ûśêd́ âś ŝṕêćîf́îéd̂ f́ôŕ êĺêḿêńt̂ ŕôĺêś" + "message": "ÂŔÎÁ ât́t̂ŕîb́ût́êś âŕê ńôt́ ûśêd́ âś ŝṕêćîf́îéd̂ f́ôŕ t̂h́ê él̂ém̂én̂t́'ŝ ŕôĺê" }, "core/audits/accessibility/aria-conditional-attr.js | title": { - "message": "ÂŔÎÁ ât́t̂ŕîb́ût́êś âŕê úŝéd̂ áŝ śp̂éĉíf̂íêd́ f̂ór̂ él̂ém̂én̂t́ r̂ól̂éŝ" + "message": "ÂŔÎÁ ât́t̂ŕîb́ût́êś âŕê úŝéd̂ áŝ śp̂éĉíf̂íêd́ f̂ór̂ t́ĥé êĺêḿêńt̂'ś r̂ól̂é" }, "core/audits/accessibility/aria-deprecated-role.js | description": { - "message": "D̂ép̂ŕêćât́êd́ ÂŔÎÁ r̂ól̂éŝ ẃîĺl̂ ńôt́ b̂é p̂ŕôćêśŝéd̂ ćôŕr̂éĉt́l̂ý b̂ý ŝćr̂éêń r̂éâd́êŕŝ. [Ĺêár̂ń m̂ór̂é âb́ôút̂ d́êṕr̂éĉát̂éd̂ ÁR̂ÍÂ ŕôĺêś](https://dequeuniversity.com/rules/axe/4.9/aria-deprecated-role)." + "message": "D̂ép̂ŕêćât́êd́ ÂŔÎÁ r̂ól̂éŝ ḿâý n̂ót̂ b́ê ṕr̂óĉéŝśêd́ ĉór̂ŕêćt̂ĺŷ b́ŷ áŝśîśt̂ív̂é t̂éĉh́n̂ól̂óĝý. [L̂éâŕn̂ ḿôŕê áb̂óût́ d̂ép̂ŕêćât́êd́ ÂŔÎÁ r̂ól̂éŝ](https://dequeuniversity.com/rules/axe/4.9/aria-deprecated-role)." }, "core/audits/accessibility/aria-deprecated-role.js | failureTitle": { "message": "D̂ép̂ŕêćât́êd́ ÂŔÎÁ r̂ól̂éŝ ẃêŕê úŝéd̂" @@ -108,13 +108,13 @@ "message": "ÂŔÎÁ `progressbar` êĺêḿêńt̂ś ĥáv̂é âćĉéŝśîb́l̂é n̂ám̂éŝ" }, "core/audits/accessibility/aria-prohibited-attr.js | description": { - "message": "Êĺêḿêńt̂ ŕôĺêś ĉán̂ ṕr̂óĥíb̂ít̂ ćêŕt̂áîń ÂŔÎÁ ât́t̂ŕîb́ût́êś f̂ŕôḿ b̂éîńĝ úŝéd̂ ón̂ t́ĥát̂ él̂ém̂én̂t́. Ûśîńĝ ón̂é ôf́ t̂h́êśê ṕr̂óĥíb̂ít̂éd̂ ŕôĺêś ĉán̂ ĺêád̂ t́ô ún̂d́êf́îńêd́ b̂éĥáv̂íôŕ b̂ý âśŝíŝt́îv́ê t́êćĥńôĺôǵŷ. [Ĺêár̂ń m̂ór̂é âb́ôút̂ ṕr̂óĥíb̂ít̂éd̂ ÁR̂ÍÂ ŕôĺêś](https://dequeuniversity.com/rules/axe/4.9/aria-prohibited-attr)." + "message": "Ûśîńĝ ÁR̂ÍÂ át̂t́r̂íb̂út̂éŝ ín̂ ŕôĺêś ŵh́êŕê t́ĥéŷ ár̂é p̂ŕôh́îb́ît́êd́ ĉán̂ ḿêán̂ t́ĥát̂ ím̂ṕôŕt̂án̂t́ îńf̂ór̂ḿât́îón̂ íŝ ńôt́ ĉóm̂ḿûńîćât́êd́ t̂ó ûśêŕŝ óf̂ áŝśîśt̂ív̂é t̂éĉh́n̂ól̂óĝíêś. [L̂éâŕn̂ ḿôŕê áb̂óût́ p̂ŕôh́îb́ît́êd́ ÂŔÎÁ r̂ól̂éŝ](https://dequeuniversity.com/rules/axe/4.9/aria-prohibited-attr)." }, "core/audits/accessibility/aria-prohibited-attr.js | failureTitle": { "message": "Êĺêḿêńt̂ś ûśê ṕr̂óĥíb̂ít̂éd̂ ÁR̂ÍÂ át̂t́r̂íb̂út̂éŝ" }, "core/audits/accessibility/aria-prohibited-attr.js | title": { - "message": "Êĺêḿêńt̂ś ôńl̂ý ûśê ṕêŕm̂ít̂t́êd́ ÂŔÎÁ ât́t̂ŕîb́ût́êś" + "message": "Êĺêḿêńt̂ś ûśê ón̂ĺŷ ṕêŕm̂ít̂t́êd́ ÂŔÎÁ ât́t̂ŕîb́ût́êś" }, "core/audits/accessibility/aria-required-attr.js | description": { "message": "Ŝóm̂é ÂŔÎÁ r̂ól̂éŝ h́âv́ê ŕêq́ûír̂éd̂ át̂t́r̂íb̂út̂éŝ t́ĥát̂ d́êśĉŕîb́ê t́ĥé ŝt́ât́ê óf̂ t́ĥé êĺêḿêńt̂ t́ô śĉŕêén̂ ŕêád̂ér̂ś. [L̂éâŕn̂ ḿôŕê áb̂óût́ r̂ól̂éŝ án̂d́ r̂éq̂úîŕêd́ ât́t̂ŕîb́ût́êś](https://dequeuniversity.com/rules/axe/4.9/aria-required-attr)."