feedback.

GoogleChrome · Apr 14, 2017 · 111a0c8 · 111a0c8
1 parent b2d2b42
commit 111a0c8
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/lighthouse-core/report/v2/renderer/details-renderer.js b/lighthouse-core/report/v2/renderer/details-renderer.js
@@ -87,7 +87,7 @@ class DetailsRenderer {
 
 if (typeof module !== 'undefined' && module.exports) {
   module.exports = DetailsRenderer;
-} else if (self) {
+} else {
   self.DetailsRenderer = DetailsRenderer;
 }
 

diff --git a/lighthouse-core/report/v2/renderer/dom.js b/lighthouse-core/report/v2/renderer/dom.js
@@ -95,6 +95,6 @@ class DOM {
 
 if (typeof module !== 'undefined' && module.exports) {
   module.exports = DOM;
-} else if (self) {
+} else {
   self.DOM = DOM;
 }
diff --git a/lighthouse-core/report/v2/renderer/report-renderer.js b/lighthouse-core/report/v2/renderer/report-renderer.js
@@ -56,12 +56,12 @@ function formatNumber(number) {
 
 class ReportRenderer {
   /**
-   * @param {!Document} document
    * @param {!DOM} DOM
    * @param {!DetailsRenderer} DetailsRenderer
    */
-  constructor(document, DOM, DetailsRenderer) {
-    this._detailsRenderer = new DetailsRenderer(this._dom);
+  constructor(dom, detailsRenderer) {
+    this._dom = dom;
+    this._detailsRenderer = detailsRenderer;
   }
 
   /**
@@ -184,7 +184,7 @@ class ReportRenderer {
 
 if (typeof module !== 'undefined' && module.exports) {
   module.exports = ReportRenderer;
-} else if (self) {
+} else {
   self.ReportRenderer = ReportRenderer;
 }
 

diff --git a/lighthouse-core/report/v2/report-template.html b/lighthouse-core/report/v2/report-template.html
@@ -30,8 +30,11 @@
   <script>%%LIGHTHOUSE_JAVASCRIPT%%</script>
   <script>window.__LIGHTHOUSE_JSON__ = %%LIGHTHOUSE_JSON%%;</script>
   <script>
-    const renderer = new ReportRenderer(document, DOM, DetailsRenderer);
-    document.body.appendChild(renderer.renderReport(window.__LIGHTHOUSE_JSON__));
+    const dom = new DOM(document);
+    const detailsRenderer = new DetailsRenderer(dom);
+    const renderer = new ReportRenderer(dom, detailsRenderer);
+    const reportElem = renderer.renderReport(window.__LIGHTHOUSE_JSON__);
+    document.body.appendChild(reportElem);
   </script>
 </body>
 </html>