From 3f7e50dd68bcf81fcb9171d5bc09b5d7bd2f0ea9 Mon Sep 17 00:00:00 2001
From: Matt Zeunert <matt@mostlystatic.com>
Date: Sun, 20 Jan 2019 09:56:43 +0000
Subject: [PATCH] Fix show omitted lines indicator at end in expanded mode

---
 .../report/html/renderer/code-snippet-renderer.js            | 2 +-
 .../test/report/html/renderer/code-snippet-renderer-test.js  | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/lighthouse-core/report/html/renderer/code-snippet-renderer.js b/lighthouse-core/report/html/renderer/code-snippet-renderer.js
index 5b80a13406a5..99f4949bedb2 100644
--- a/lighthouse-core/report/html/renderer/code-snippet-renderer.js
+++ b/lighthouse-core/report/html/renderer/code-snippet-renderer.js
@@ -165,7 +165,7 @@ class CodeSnippetRenderer {
     }
     if (!lastLineIsVisible) {
       snippet.append(CodeSnippetRenderer.renderOmittedLines(dom, tmpl,
-        LineVisibility.WHEN_COLLAPSED
+        LineVisibility.WHEN_EXPANDED
       ));
     }
 
diff --git a/lighthouse-core/test/report/html/renderer/code-snippet-renderer-test.js b/lighthouse-core/test/report/html/renderer/code-snippet-renderer-test.js
index bf46dccc9190..5b261082d911 100644
--- a/lighthouse-core/test/report/html/renderer/code-snippet-renderer-test.js
+++ b/lighthouse-core/test/report/html/renderer/code-snippet-renderer-test.js
@@ -105,7 +105,12 @@ describe('DetailsRenderer', () => {
     const visibleLines = el.querySelectorAll(
       '.lh-code-snippet__line--code:not(.lh-code-snippet__show-if-expanded)');
     const lastVisibleLine = visibleLines[visibleLines.length - 1];
+    const omittedLinesIndicators = el.querySelectorAll('.lh-code-snippet__line--empty');
+
     // Shows first 5 visible lines
     assert.equal(lastVisibleLine.textContent.replace(/\s/g, ''), '5E');
+    // "..." after the available lines, but only shows in expanded state
+    assert.equal(omittedLinesIndicators.length, 1);
+    assert.ok(omittedLinesIndicators[0].classList.contains('lh-code-snippet__show-if-expanded'));
   });
 });