From 46e49f4eef72453fa61c8bc1f2430899f74dd12d Mon Sep 17 00:00:00 2001 From: Paul Irish Date: Thu, 17 May 2018 13:51:46 -0700 Subject: [PATCH] misc(viewer): fix saving as gist (#5251) --- lighthouse-core/report/html/renderer/report-ui-features.js | 2 +- lighthouse-core/scripts/roll-to-devtools.sh | 2 +- lighthouse-viewer/app/src/github-api.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lighthouse-core/report/html/renderer/report-ui-features.js b/lighthouse-core/report/html/renderer/report-ui-features.js index 2d3c8ee8e22e..20c0cd128b64 100644 --- a/lighthouse-core/report/html/renderer/report-ui-features.js +++ b/lighthouse-core/report/html/renderer/report-ui-features.js @@ -291,7 +291,7 @@ class ReportUIFeatures { const el = /** @type {?Element} */ (e.target); - if (!el || el.hasAttribute('data-action')) { + if (!el || !el.hasAttribute('data-action')) { return; } diff --git a/lighthouse-core/scripts/roll-to-devtools.sh b/lighthouse-core/scripts/roll-to-devtools.sh index 0736397e14df..c373c7276ffd 100755 --- a/lighthouse-core/scripts/roll-to-devtools.sh +++ b/lighthouse-core/scripts/roll-to-devtools.sh @@ -18,7 +18,7 @@ chromium_dir="$HOME/chromium/src" if [[ -n "$1" ]]; then frontend_dir="$1" else - frontend_dir="$chromium_dir/third_party/WebKit/Source/devtools/front_end" + frontend_dir="$chromium_dir/third_party/blink/renderer/devtools/front_end" fi if [[ ! -d "$frontend_dir" || ! -a "$frontend_dir/Runtime.js" ]]; then diff --git a/lighthouse-viewer/app/src/github-api.js b/lighthouse-viewer/app/src/github-api.js index 804e33a24323..f6e08658f875 100644 --- a/lighthouse-viewer/app/src/github-api.js +++ b/lighthouse-viewer/app/src/github-api.js @@ -36,7 +36,7 @@ class GithubApi { return this._auth.getAccessToken() .then(accessToken => { const filename = getFilenamePrefix({ - url: jsonFile.url, + finalUrl: jsonFile.finalUrl, fetchTime: jsonFile.fetchTime, }); const body = {