From 62e4b741accf2875828d2a1b8ea731527db1276b Mon Sep 17 00:00:00 2001 From: Brendan Kenny Date: Fri, 13 Oct 2017 14:17:03 -0700 Subject: [PATCH] core(image-aspect-ratio): pass audit when no images are missized (#3552) also add smoke test for image-aspect-ratio --- .../test/fixtures/dobetterweb/dbw_tester.html | 6 +++ .../dobetterweb/lighthouse-480x318.jpg | Bin 0 -> 24620 bytes .../dobetterweb/dbw-expectations.js | 17 ++++++++- lighthouse-core/audits/image-aspect-ratio.js | 2 +- .../test/audits/image-aspect-ratio-test.js | 36 ++++++++++++------ 5 files changed, 46 insertions(+), 15 deletions(-) create mode 100644 lighthouse-cli/test/fixtures/dobetterweb/lighthouse-480x318.jpg diff --git a/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html b/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html index a99969298073..1bdd9f121884 100644 --- a/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html +++ b/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html @@ -116,6 +116,12 @@

Do better web tester page

+ + + + + +