Skip to content

Commit

Permalink
core(installable-manifest): use monospace for technical terms in stri…
Browse files Browse the repository at this point in the history
…ngs (#15513)
  • Loading branch information
connorjclark committed Oct 3, 2023
1 parent 7f9a228 commit fa70317
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions core/audits/installable-manifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ const UIStrings = {
/** Error message explaining that the provided manifest URL is invalid. */
'start-url-not-valid': `Manifest start URL is not valid`,
/** Error message explaining that the provided manifest does not contain a name or short_name field. */
'manifest-missing-name-or-short-name': `Manifest does not contain a 'name' or 'short_name' field`,
'manifest-missing-name-or-short-name': 'Manifest does not contain a `name` or `short_name` field',
/** Error message explaining that the manifest display property must be one of 'standalone', 'fullscreen', or 'minimal-ui'. */
'manifest-display-not-supported': `Manifest 'display' property must be one of 'standalone', 'fullscreen', or 'minimal-ui'`,
'manifest-display-not-supported': 'Manifest `display` property must be one of `standalone`, `fullscreen`, or `minimal-ui`',
/** Error message explaining that the manifest could not be fetched, might be empty, or could not be parsed. */
'manifest-empty': `Manifest could not be fetched, is empty, or could not be parsed`,
/**
Expand Down
2 changes: 1 addition & 1 deletion core/test/audits/installable-manifest-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ describe('PWA: webapp install banner audit', () => {
return InstallableManifestAudit.audit(artifacts, context).then(result => {
assert.strictEqual(result.score, 0);
const items = result.details.items;
expect(items[0].reason).toBeDisplayString(/does not contain a 'name'/);
expect(items[0].reason).toBeDisplayString(/does not contain a `name`/);
});
});

Expand Down
4 changes: 2 additions & 2 deletions shared/localization/locales/en-US.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions shared/localization/locales/en-XL.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 comment on commit fa70317

@vercel
Copy link

@vercel vercel bot commented on fa70317 Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

lighthouse – ./

lighthouse-googlechrome.vercel.app
lighthouse-git-main-googlechrome.vercel.app

Please sign in to comment.