Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ImageElements artifact #11642

Closed
3 tasks done
paulirish opened this issue Nov 9, 2020 · 0 comments
Closed
3 tasks done

Update ImageElements artifact #11642

paulirish opened this issue Nov 9, 2020 · 0 comments
Assignees
@adrianaixba
Labels
breaking P1.5

Comments

@paulirish
Copy link
Member

paulirish commented Nov 9, 2020 •
edited
Loading

breaking changes for v7:

  • ImageElements: replace all the usesX (usesObjectFit, usesPixelArtScaling, etc) boolean properties in ImageElements with their raw property equivalents instead
  • ImageElements: Make naturalWidth/naturalHeight optional in ImageElements, don't set for <picture> images until we're sure (ref Displays images with inappropriate size #11450)
  • ImageElements: Remove duplicated resourceSize in ImageElements that duplicates network record property.
    • PR in the works.

ref #11207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrianaixba adrianaixba

Labels
breaking P1.5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulirish @adrianaixba