Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No dogfood #3074

Closed
Tsaukpaetra opened this issue Aug 22, 2017 · 4 comments
Closed

No dogfood #3074

Tsaukpaetra opened this issue Aug 22, 2017 · 4 comments

Comments

@Tsaukpaetra
Copy link

I clicked the lighthouse on https://developers.google.com/web/tools/lighthouse/
It epicly failed the page.

Heck, even https://www.google.com gave me abysmal results:

https://pastebin.com/XEKLKctP

What's going on here?

@patrickhulce
Copy link
Collaborator

@Tsaukpaetra those results for google.com look extremely unusual. Does it really take 17 seconds to load for you? In these cases it's almost always been another extension or antivirus software interfering with the run. A trace of your load (obtained via the CLI with the --save-assets flag) would be the best way for us to diagnose why it took so long.

The below results are what you should expect from google.com or any well-built site that hasn't been made a PWA.
image

image

This did help uncover a bug in one of our best practices audits though :) #3079

@VaultDwe11er
Copy link

Interestingly I just tested google.co.za, and it gives me similar results to google.com, except for a score of 69 on "Best Practices" (vs 77 on google.com). The difference seems to be that google.co.za has an additional failure for "Requests the geolocation permission on page load". There's nothing like free QA, right? 😉

@patrickhulce
Copy link
Collaborator

Heh the "Requests the geolocation permission on page load" is a dicey one for quite a few searches as well. It's starts entering arguable territory whether a search navigation is a user gesture where one might expect the prompt, not a page load. For example, if Google were an SPA that prompted you on entering into a search box instead of form submission, it'd pass the audit.

@VaultDwe11er
Copy link

I understand what you're saying, it's just interesting that google.com passes the audit but google.co.za does not, is all I'm saying 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants