-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider replacing driver.evaluateAsync with new async debugger evaluate #580
Comments
the |
Would it be a lot of work to support both? With a feature check? (not sure how __returnResults is used atm) |
We could "feature-detect" the protocol to see if there's support for it, but I'd rather do the switch in a few months at once, rather than support two codepaths simultaneously. (TBH, our evaluateAsync has been totally stable, so i'm not particularly concerned about maintenance, but we're not in any rush either.) |
That's true :) perhaps add a milestone or a label to it. |
cc @ak239 |
Should simplify it a good bit. Will require all client-side scripts to evaluate to a promise (instead of calling
__returnResults
)https://chromedevtools.github.io/debugger-protocol-viewer/tot/Runtime/#method-evaluate
The text was updated successfully, but these errors were encountered: