Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Preconnect to required origins" should not come up #6676

Closed
cihati opened this issue Nov 28, 2018 · 5 comments
Closed

"Preconnect to required origins" should not come up #6676

cihati opened this issue Nov 28, 2018 · 5 comments
Assignees

Comments

@cihati
Copy link

cihati commented Nov 28, 2018

Provide the steps to reproduce

  1. Run LH on https://fatllama.com

What is the current behavior?

It shows this suggestion.

What is the expected behavior?

It doesn't show this suggestion, as I already preconnect to 5 domains in the homepage:

    <!-- preconnect 5 most costly connections https://www.webpagetest.org/forums/showthread.php?tid=15317 -->
    <link rel='preconnect' href='//api.segment.io' />
    <link rel='preconnect' href='//stats.pusher.com' />
    <link rel='preconnect' href='//m.stripe.com' />
    <link rel='preconnect' href='//www.google-analytics.com' />
    <link rel='preconnect' href='//js.intercomcdn.com' />
    <!-- preconnect end -->

According to #3106 , no more than 5 preconnections should be done for best performance. LH asks me to do a lot more:
image

Environment Information

  • Affected Channels: DevTools
  • Lighthouse version: Chrome Version 70.0.3538.110 (Official Build) (64-bit)
  • Node.js version:
  • Operating System: MacOS High Sierra

Related issues
#3106

@patrickhulce patrickhulce self-assigned this Nov 28, 2018
@patrickhulce
Copy link
Collaborator

Thanks for filing @cihati! Some good news/bad news

Looking at the webpagetest results for your page, it looks like not all of the preconnect directives are being respected by Chrome. 😢

In latest version of Lighthouse I just tested though, we're not telling you to preload the ones that are successfully being preloaded in the WPT results though 😃

I think we'll fix this by fetching the links in your HTML to double check 👍

@cihati
Copy link
Author

cihati commented Nov 29, 2018

Thanks for the quick reply, @patrickhulce

@wardpeet
Copy link
Collaborator

wardpeet commented Nov 29, 2018

it's more or less a duplicate of #5932.

Thanks for filling a bug

@patrickhulce
Copy link
Collaborator

Thanks @wardpeet I thought I remembered something like this, but I couldn't find it in the moment :)

Closing in favor of #5932

@nicolaskopp
Copy link

made some more observations here: #5932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants