From 51de3f6d5e9f61663b07c48772d8769a56b65859 Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Wed, 18 Jan 2023 12:59:15 -0800 Subject: [PATCH 1/5] deps: upgrade `axe-core` to 4.6.2 --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 5a6f36f9b499..72d5c1e573a3 100644 --- a/package.json +++ b/package.json @@ -184,7 +184,7 @@ }, "dependencies": { "@sentry/node": "^6.17.4", - "axe-core": "4.4.1", + "axe-core": "4.6.2", "chrome-launcher": "^0.15.1", "configstore": "^5.0.1", "csp_evaluator": "1.1.1", diff --git a/yarn.lock b/yarn.lock index 791095868992..e222097e5d96 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2008,10 +2008,10 @@ aws4@^1.8.0: resolved "https://registry.yarnpkg.com/aws4/-/aws4-1.8.0.tgz#f0e003d9ca9e7f59c7a508945d7b2ef9a04a542f" integrity sha512-ReZxvNHIOv88FlT7rxcXIIC0fPt4KZqZbOlivyWtXLt8ESx84zd3kMC6iK5jVeS2qt+g7ftS7ye4fi06X5rtRQ== -axe-core@4.4.1: - version "4.4.1" - resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.4.1.tgz#7dbdc25989298f9ad006645cd396782443757413" - integrity sha512-gd1kmb21kwNuWr6BQz8fv6GNECPBnUasepcoLbekws23NVBLODdsClRZ+bQ8+9Uomf3Sm3+Vwn0oYG9NvwnJCw== +axe-core@4.6.2: + version "4.6.2" + resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.6.2.tgz#6e566ab2a3d29e415f5115bc0fd2597a5eb3e5e3" + integrity sha512-b1WlTV8+XKLj9gZy2DZXgQiyDp9xkkoe2a6U6UbYccScq2wgH/YwCeI2/Jq2mgo0HzQxqJOjWZBLeA/mqsk5Mg== babel-plugin-istanbul@^6.1.1: version "6.1.1" From d4ab38bd4d13fb2638bdb4dddc6570a22034af2d Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Wed, 18 Jan 2023 13:27:09 -0800 Subject: [PATCH 2/5] half smoke --- cli/test/smokehouse/test-definitions/a11y.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cli/test/smokehouse/test-definitions/a11y.js b/cli/test/smokehouse/test-definitions/a11y.js index 7e9b61c4dae5..26077972c7f1 100644 --- a/cli/test/smokehouse/test-definitions/a11y.js +++ b/cli/test/smokehouse/test-definitions/a11y.js @@ -360,7 +360,7 @@ const expectations = { 'type': 'node', 'selector': 'body > section > dl#definition-list', 'snippet': '
', - 'explanation': 'Fix all of the following:\n List element has direct children that are not allowed inside
or
elements', + 'explanation': 'Fix all of the following:\n dl element has direct children that are not allowed: p', 'nodeLabel': 'body > section > dl#definition-list', }, }, @@ -627,7 +627,7 @@ const expectations = { 'type': 'node', 'selector': 'body > section > ul#list', 'snippet': '
    ', - 'explanation': 'Fix all of the following:\n List element has direct children that are not allowed inside
  • elements', + 'explanation': 'Fix all of the following:\n List element has direct children that are not allowed: p', 'nodeLabel': 'body > section > ul#list', }, }, From 711dd36c583aed748ef0a157b54ffd87dac4fa8a Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Tue, 24 Jan 2023 16:42:53 -0800 Subject: [PATCH 3/5] fix --- cli/test/fixtures/a11y/a11y_tester.html | 6 +++--- cli/test/smokehouse/test-definitions/a11y.js | 8 ++++---- package.json | 2 +- yarn.lock | 8 ++++---- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/cli/test/fixtures/a11y/a11y_tester.html b/cli/test/fixtures/a11y/a11y_tester.html index 9e997fcb3e90..61742ae6d812 100644 --- a/cli/test/fixtures/a11y/a11y_tester.html +++ b/cli/test/fixtures/a11y/a11y_tester.html @@ -67,8 +67,8 @@
    -
    + role="list"> +
    Item

    aria-required-parent

    @@ -190,7 +190,7 @@

    sub-sub-header

    object-alt

    - +

    tabindex

    diff --git a/cli/test/smokehouse/test-definitions/a11y.js b/cli/test/smokehouse/test-definitions/a11y.js index 26077972c7f1..0a9173311ef3 100644 --- a/cli/test/smokehouse/test-definitions/a11y.js +++ b/cli/test/smokehouse/test-definitions/a11y.js @@ -198,9 +198,9 @@ const expectations = { node: { 'type': 'node', 'selector': 'body > section > div#aria-required-children', - 'snippet': '
    ', - 'explanation': 'Fix any of the following:\n Required ARIA child role not present: radio', - 'nodeLabel': 'body > section > div#aria-required-children', + 'snippet': '
    ', + 'explanation': 'Fix any of the following:\n Required ARIA child role not present: listitem\n Element has no aria-busy="true" attribute', + 'nodeLabel': 'Item', }, }, ], @@ -674,7 +674,7 @@ const expectations = { node: { 'type': 'node', 'selector': 'body > section > object#object-alt', - 'snippet': '', + 'snippet': '', 'explanation': 'Fix any of the following:\n aria-label attribute does not exist or is empty\n aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty\n Element has no title attribute\n Element\'s default semantics were not overridden with role="none" or role="presentation"', 'nodeLabel': 'body > section > object#object-alt', }, diff --git a/package.json b/package.json index 1130ccd04629..f337422c08da 100644 --- a/package.json +++ b/package.json @@ -187,7 +187,7 @@ }, "dependencies": { "@sentry/node": "^6.17.4", - "axe-core": "4.6.2", + "axe-core": "4.6.3", "chrome-launcher": "^0.15.1", "configstore": "^5.0.1", "csp_evaluator": "1.1.1", diff --git a/yarn.lock b/yarn.lock index 59d52d7b1ba7..0f888e6bab29 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2008,10 +2008,10 @@ aws4@^1.8.0: resolved "https://registry.yarnpkg.com/aws4/-/aws4-1.8.0.tgz#f0e003d9ca9e7f59c7a508945d7b2ef9a04a542f" integrity sha512-ReZxvNHIOv88FlT7rxcXIIC0fPt4KZqZbOlivyWtXLt8ESx84zd3kMC6iK5jVeS2qt+g7ftS7ye4fi06X5rtRQ== -axe-core@4.6.2: - version "4.6.2" - resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.6.2.tgz#6e566ab2a3d29e415f5115bc0fd2597a5eb3e5e3" - integrity sha512-b1WlTV8+XKLj9gZy2DZXgQiyDp9xkkoe2a6U6UbYccScq2wgH/YwCeI2/Jq2mgo0HzQxqJOjWZBLeA/mqsk5Mg== +axe-core@4.6.3: + version "4.6.3" + resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.6.3.tgz#fc0db6fdb65cc7a80ccf85286d91d64ababa3ece" + integrity sha512-/BQzOX780JhsxDnPpH4ZiyrJAzcd8AfzFPkv+89veFSr1rcMjuq2JDCwypKaPeB6ljHp9KjXhPpjgCvQlWYuqg== babel-plugin-istanbul@^6.1.1: version "6.1.1" From 80c619f0bfd0bf29daa09690054965c2e520c773 Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Tue, 24 Jan 2023 16:47:35 -0800 Subject: [PATCH 4/5] unit --- core/gather/gatherers/accessibility.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/gather/gatherers/accessibility.js b/core/gather/gatherers/accessibility.js index 3b6d6d43621d..3bed60499ba0 100644 --- a/core/gather/gatherers/accessibility.js +++ b/core/gather/gatherers/accessibility.js @@ -61,10 +61,12 @@ async function runA11yChecks() { 'frame-focusable-content': {enabled: false}, 'aria-roledescription': {enabled: false}, 'scrollable-region-focusable': {enabled: false}, - // TODO(paulirish): create audits and enable these 3. + // TODO(paulirish): create audits and enable these 5. 'input-button-name': {enabled: false}, 'role-img-alt': {enabled: false}, 'select-name': {enabled: false}, + 'link-in-text-block': {enabled: false}, + 'frame-title-unique': {enabled: false}, }, }); From 4ad4d308a09120af7f1ee498eb987bbfa6cbdc7e Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Tue, 24 Jan 2023 16:56:35 -0800 Subject: [PATCH 5/5] doc links --- core/audits/accessibility/accesskeys.js | 2 +- .../audits/accessibility/aria-allowed-attr.js | 2 +- .../audits/accessibility/aria-command-name.js | 2 +- core/audits/accessibility/aria-hidden-body.js | 2 +- .../audits/accessibility/aria-hidden-focus.js | 2 +- .../accessibility/aria-input-field-name.js | 2 +- core/audits/accessibility/aria-meter-name.js | 2 +- .../accessibility/aria-progressbar-name.js | 2 +- .../accessibility/aria-required-attr.js | 2 +- .../accessibility/aria-required-children.js | 2 +- .../accessibility/aria-required-parent.js | 2 +- core/audits/accessibility/aria-roles.js | 2 +- .../accessibility/aria-toggle-field-name.js | 2 +- .../audits/accessibility/aria-tooltip-name.js | 2 +- .../accessibility/aria-treeitem-name.js | 2 +- .../accessibility/aria-valid-attr-value.js | 2 +- core/audits/accessibility/aria-valid-attr.js | 2 +- core/audits/accessibility/button-name.js | 2 +- core/audits/accessibility/bypass.js | 2 +- core/audits/accessibility/color-contrast.js | 2 +- core/audits/accessibility/definition-list.js | 2 +- core/audits/accessibility/dlitem.js | 2 +- core/audits/accessibility/document-title.js | 2 +- .../accessibility/duplicate-id-active.js | 2 +- .../audits/accessibility/duplicate-id-aria.js | 2 +- .../form-field-multiple-labels.js | 2 +- core/audits/accessibility/frame-title.js | 2 +- core/audits/accessibility/heading-order.js | 2 +- core/audits/accessibility/html-has-lang.js | 2 +- core/audits/accessibility/html-lang-valid.js | 2 +- core/audits/accessibility/image-alt.js | 2 +- core/audits/accessibility/input-image-alt.js | 2 +- core/audits/accessibility/label.js | 2 +- core/audits/accessibility/link-name.js | 2 +- core/audits/accessibility/list.js | 2 +- core/audits/accessibility/listitem.js | 2 +- core/audits/accessibility/meta-refresh.js | 2 +- core/audits/accessibility/meta-viewport.js | 2 +- core/audits/accessibility/object-alt.js | 2 +- core/audits/accessibility/tabindex.js | 2 +- core/audits/accessibility/td-headers-attr.js | 2 +- .../audits/accessibility/th-has-data-cells.js | 2 +- core/audits/accessibility/valid-lang.js | 2 +- core/audits/accessibility/video-caption.js | 2 +- .../reports/sample-flow-result.json | 264 +++++++++--------- core/test/results/sample_v2.json | 88 +++--- shared/localization/locales/en-US.json | 88 +++--- shared/localization/locales/en-XL.json | 88 +++--- 48 files changed, 308 insertions(+), 308 deletions(-) diff --git a/core/audits/accessibility/accesskeys.js b/core/audits/accessibility/accesskeys.js index a962c7b501ca..af20d0d1db24 100644 --- a/core/audits/accessibility/accesskeys.js +++ b/core/audits/accessibility/accesskeys.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Access keys let users quickly focus a part of the page. For proper ' + 'navigation, each access key must be unique. ' + - '[Learn more about access keys](https://dequeuniversity.com/rules/axe/4.4/accesskeys).', + '[Learn more about access keys](https://dequeuniversity.com/rules/axe/4.6/accesskeys).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-allowed-attr.js b/core/audits/accessibility/aria-allowed-attr.js index bbaae520447b..c16a8d512e8c 100644 --- a/core/audits/accessibility/aria-allowed-attr.js +++ b/core/audits/accessibility/aria-allowed-attr.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Each ARIA `role` supports a specific subset of `aria-*` attributes. ' + 'Mismatching these invalidates the `aria-*` attributes. [Learn ' + - 'how to match ARIA attributes to their roles](https://dequeuniversity.com/rules/axe/4.4/aria-allowed-attr).', + 'how to match ARIA attributes to their roles](https://dequeuniversity.com/rules/axe/4.6/aria-allowed-attr).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-command-name.js b/core/audits/accessibility/aria-command-name.js index 02ed8e48d077..9ff004a1047f 100644 --- a/core/audits/accessibility/aria-command-name.js +++ b/core/audits/accessibility/aria-command-name.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accessibility audit that evaluates if important HTML elements do not have accessible names. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: '`button`, `link`, and `menuitem` elements do not have accessible names.', /** Description of a Lighthouse audit that tells the user *why* they should have accessible names for HTML elements. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'When an element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to make command elements more accessible](https://dequeuniversity.com/rules/axe/4.4/aria-command-name).', + description: 'When an element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to make command elements more accessible](https://dequeuniversity.com/rules/axe/4.6/aria-command-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-hidden-body.js b/core/audits/accessibility/aria-hidden-body.js index 79e5df004b13..6562853d25b6 100644 --- a/core/audits/accessibility/aria-hidden-body.js +++ b/core/audits/accessibility/aria-hidden-body.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accesibility audit that checks if the html element does not have an aria-hidden attribute set on it. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: '`[aria-hidden="true"]` is present on the document ``', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'Assistive technologies, like screen readers, work inconsistently when `aria-hidden="true"` is set on the document ``. [Learn how `aria-hidden` affects the document body](https://dequeuniversity.com/rules/axe/4.4/aria-hidden-body).', + description: 'Assistive technologies, like screen readers, work inconsistently when `aria-hidden="true"` is set on the document ``. [Learn how `aria-hidden` affects the document body](https://dequeuniversity.com/rules/axe/4.6/aria-hidden-body).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-hidden-focus.js b/core/audits/accessibility/aria-hidden-focus.js index 875bd30936aa..5934b1b525d2 100644 --- a/core/audits/accessibility/aria-hidden-focus.js +++ b/core/audits/accessibility/aria-hidden-focus.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accesibility audit that checks if all elements that have an aria-hidden attribute do not contain focusable descendent elements. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: '`[aria-hidden="true"]` elements contain focusable descendents', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'Focusable descendents within an `[aria-hidden="true"]` element prevent those interactive elements from being available to users of assistive technologies like screen readers. [Learn how `aria-hidden` affects focusable elements](https://dequeuniversity.com/rules/axe/4.4/aria-hidden-focus).', + description: 'Focusable descendents within an `[aria-hidden="true"]` element prevent those interactive elements from being available to users of assistive technologies like screen readers. [Learn how `aria-hidden` affects focusable elements](https://dequeuniversity.com/rules/axe/4.6/aria-hidden-focus).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-input-field-name.js b/core/audits/accessibility/aria-input-field-name.js index 193cc89e6400..423266b1ab72 100644 --- a/core/audits/accessibility/aria-input-field-name.js +++ b/core/audits/accessibility/aria-input-field-name.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accesibility audit that checks that all ARIA input fields have an accessible name. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'ARIA input fields do not have accessible names', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'When an input field doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn more about input field labels](https://dequeuniversity.com/rules/axe/4.4/aria-input-field-name).', + description: 'When an input field doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn more about input field labels](https://dequeuniversity.com/rules/axe/4.6/aria-input-field-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-meter-name.js b/core/audits/accessibility/aria-meter-name.js index d7ea6fc31dd7..7edda5531cc1 100644 --- a/core/audits/accessibility/aria-meter-name.js +++ b/core/audits/accessibility/aria-meter-name.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accessibility audit that evaluates if meter HTML elements do not have accessible names. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'ARIA `meter` elements do not have accessible names.', /** Description of a Lighthouse audit that tells the user *why* they should have accessible names for HTML 'meter' elements. This is displayed after a user expands the section to see more. No character length limits. 'Learn how...' becomes link text to additional documentation. */ - description: 'When a meter element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to name `meter` elements](https://dequeuniversity.com/rules/axe/4.4/aria-meter-name).', + description: 'When a meter element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to name `meter` elements](https://dequeuniversity.com/rules/axe/4.6/aria-meter-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-progressbar-name.js b/core/audits/accessibility/aria-progressbar-name.js index 26bd0980ac2a..7e79610c2275 100644 --- a/core/audits/accessibility/aria-progressbar-name.js +++ b/core/audits/accessibility/aria-progressbar-name.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accessibility audit that evaluates if progressbar HTML elements do not have accessible names. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'ARIA `progressbar` elements do not have accessible names.', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'When a `progressbar` element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to label `progressbar` elements](https://dequeuniversity.com/rules/axe/4.4/aria-progressbar-name).', + description: 'When a `progressbar` element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to label `progressbar` elements](https://dequeuniversity.com/rules/axe/4.6/aria-progressbar-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-required-attr.js b/core/audits/accessibility/aria-required-attr.js index 7e222b6ffe06..9db99ebc635f 100644 --- a/core/audits/accessibility/aria-required-attr.js +++ b/core/audits/accessibility/aria-required-attr.js @@ -19,7 +19,7 @@ const UIStrings = { failureTitle: '`[role]`s do not have all required `[aria-*]` attributes', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Some ARIA roles have required attributes that describe the state ' + - 'of the element to screen readers. [Learn more about roles and required attributes](https://dequeuniversity.com/rules/axe/4.4/aria-required-attr).', + 'of the element to screen readers. [Learn more about roles and required attributes](https://dequeuniversity.com/rules/axe/4.6/aria-required-attr).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-required-children.js b/core/audits/accessibility/aria-required-children.js index 5f0835e163fc..682f6e378632 100644 --- a/core/audits/accessibility/aria-required-children.js +++ b/core/audits/accessibility/aria-required-children.js @@ -23,7 +23,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Some ARIA parent roles must contain specific child roles to perform ' + 'their intended accessibility functions. ' + - '[Learn more about roles and required children elements](https://dequeuniversity.com/rules/axe/4.4/aria-required-children).', + '[Learn more about roles and required children elements](https://dequeuniversity.com/rules/axe/4.6/aria-required-children).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-required-parent.js b/core/audits/accessibility/aria-required-parent.js index 5aa47b111afb..e60f5dd4d852 100644 --- a/core/audits/accessibility/aria-required-parent.js +++ b/core/audits/accessibility/aria-required-parent.js @@ -21,7 +21,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Some ARIA child roles must be contained by specific parent roles to ' + 'properly perform their intended accessibility functions. ' + - '[Learn more about ARIA roles and required parent element](https://dequeuniversity.com/rules/axe/4.4/aria-required-parent).', + '[Learn more about ARIA roles and required parent element](https://dequeuniversity.com/rules/axe/4.6/aria-required-parent).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-roles.js b/core/audits/accessibility/aria-roles.js index 418d4104a295..06119b22d2bb 100644 --- a/core/audits/accessibility/aria-roles.js +++ b/core/audits/accessibility/aria-roles.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'ARIA roles must have valid values in order to perform their ' + 'intended accessibility functions. ' + - '[Learn more about valid ARIA roles](https://dequeuniversity.com/rules/axe/4.4/aria-roles).', + '[Learn more about valid ARIA roles](https://dequeuniversity.com/rules/axe/4.6/aria-roles).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-toggle-field-name.js b/core/audits/accessibility/aria-toggle-field-name.js index 2a71250246b5..ed5efaeffd12 100644 --- a/core/audits/accessibility/aria-toggle-field-name.js +++ b/core/audits/accessibility/aria-toggle-field-name.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accesibility audit that checks that all ARIA toggle fields have an accessible name. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'ARIA toggle fields do not have accessible names', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'When a toggle field doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn more about toggle fields](https://dequeuniversity.com/rules/axe/4.4/aria-toggle-field-name).', + description: 'When a toggle field doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn more about toggle fields](https://dequeuniversity.com/rules/axe/4.6/aria-toggle-field-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-tooltip-name.js b/core/audits/accessibility/aria-tooltip-name.js index 1a4e5683cd5d..862fde099eb4 100644 --- a/core/audits/accessibility/aria-tooltip-name.js +++ b/core/audits/accessibility/aria-tooltip-name.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accessibility audit that evaluates if tooltip HTML elements do not have accessible names. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'ARIA `tooltip` elements do not have accessible names.', /** Description of a Lighthouse audit that tells the user *why* they should have accessible names for HTML 'tooltip' elements. This is displayed after a user expands the section to see more. No character length limits. 'Learn how...' becomes link text to additional documentation. */ - description: 'When a tooltip element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to name `tooltip` elements](https://dequeuniversity.com/rules/axe/4.4/aria-tooltip-name).', + description: 'When a tooltip element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn how to name `tooltip` elements](https://dequeuniversity.com/rules/axe/4.6/aria-tooltip-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-treeitem-name.js b/core/audits/accessibility/aria-treeitem-name.js index 69e8cc2fad32..07ea58bc3a81 100644 --- a/core/audits/accessibility/aria-treeitem-name.js +++ b/core/audits/accessibility/aria-treeitem-name.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accessibility audit that evaluates if treeitem HTML elements do not have accessible names. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'ARIA `treeitem` elements do not have accessible names.', /** Description of a Lighthouse audit that tells the user *why* they should have accessible names for HTML elements. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'When a `treeitem` element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn more about labeling `treeitem` elements](https://dequeuniversity.com/rules/axe/4.4/aria-treeitem-name).', + description: 'When a `treeitem` element doesn\'t have an accessible name, screen readers announce it with a generic name, making it unusable for users who rely on screen readers. [Learn more about labeling `treeitem` elements](https://dequeuniversity.com/rules/axe/4.6/aria-treeitem-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-valid-attr-value.js b/core/audits/accessibility/aria-valid-attr-value.js index 903bacb5813d..dda0f6d03411 100644 --- a/core/audits/accessibility/aria-valid-attr-value.js +++ b/core/audits/accessibility/aria-valid-attr-value.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Assistive technologies, like screen readers, can\'t interpret ARIA ' + 'attributes with invalid values. [Learn ' + - 'more about valid values for ARIA attributes](https://dequeuniversity.com/rules/axe/4.4/aria-valid-attr-value).', + 'more about valid values for ARIA attributes](https://dequeuniversity.com/rules/axe/4.6/aria-valid-attr-value).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/aria-valid-attr.js b/core/audits/accessibility/aria-valid-attr.js index a75fa984352c..d371de78dcb0 100644 --- a/core/audits/accessibility/aria-valid-attr.js +++ b/core/audits/accessibility/aria-valid-attr.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Assistive technologies, like screen readers, can\'t interpret ARIA ' + 'attributes with invalid names. [Learn ' + - 'more about valid ARIA attributes](https://dequeuniversity.com/rules/axe/4.4/aria-valid-attr).', + 'more about valid ARIA attributes](https://dequeuniversity.com/rules/axe/4.6/aria-valid-attr).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/button-name.js b/core/audits/accessibility/button-name.js index eb42f932ab95..33c0f28f6252 100644 --- a/core/audits/accessibility/button-name.js +++ b/core/audits/accessibility/button-name.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'When a button doesn\'t have an accessible name, screen readers announce it ' + 'as "button", making it unusable for users who rely on screen readers. ' + - '[Learn how to make buttons more accessible](https://dequeuniversity.com/rules/axe/4.4/button-name).', + '[Learn how to make buttons more accessible](https://dequeuniversity.com/rules/axe/4.6/button-name).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/bypass.js b/core/audits/accessibility/bypass.js index 25773516ba90..2dd912a6a39f 100644 --- a/core/audits/accessibility/bypass.js +++ b/core/audits/accessibility/bypass.js @@ -21,7 +21,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Adding ways to bypass repetitive content lets keyboard users navigate the ' + 'page more efficiently. ' + - '[Learn more about bypass blocks](https://dequeuniversity.com/rules/axe/4.4/bypass).', + '[Learn more about bypass blocks](https://dequeuniversity.com/rules/axe/4.6/bypass).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/color-contrast.js b/core/audits/accessibility/color-contrast.js index 07ab6cd02d3c..c9707751734d 100644 --- a/core/audits/accessibility/color-contrast.js +++ b/core/audits/accessibility/color-contrast.js @@ -21,7 +21,7 @@ const UIStrings = { 'sufficient contrast ratio.', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Low-contrast text is difficult or impossible for many users to read. ' + - '[Learn how to provide sufficient color contrast](https://dequeuniversity.com/rules/axe/4.4/color-contrast).', + '[Learn how to provide sufficient color contrast](https://dequeuniversity.com/rules/axe/4.6/color-contrast).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/definition-list.js b/core/audits/accessibility/definition-list.js index 9711eb5a7308..c654eee77a83 100644 --- a/core/audits/accessibility/definition-list.js +++ b/core/audits/accessibility/definition-list.js @@ -22,7 +22,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'When definition lists are not properly marked up, screen readers may produce ' + 'confusing or inaccurate output. ' + - '[Learn how to structure definition lists correctly](https://dequeuniversity.com/rules/axe/4.4/definition-list).', + '[Learn how to structure definition lists correctly](https://dequeuniversity.com/rules/axe/4.6/definition-list).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/dlitem.js b/core/audits/accessibility/dlitem.js index cd1d2dfa6faa..6b16b418832c 100644 --- a/core/audits/accessibility/dlitem.js +++ b/core/audits/accessibility/dlitem.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'Definition list items (`
    ` and `
    `) must be wrapped in a ' + 'parent `
    ` element to ensure that screen readers can properly announce them. ' + - '[Learn how to structure definition lists correctly](https://dequeuniversity.com/rules/axe/4.4/dlitem).', + '[Learn how to structure definition lists correctly](https://dequeuniversity.com/rules/axe/4.6/dlitem).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/document-title.js b/core/audits/accessibility/document-title.js index 5fdf6388f7d5..50adbd45d24f 100644 --- a/core/audits/accessibility/document-title.js +++ b/core/audits/accessibility/document-title.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ description: 'The title gives screen reader users an overview of the page, and search ' + 'engine users rely on it heavily to determine if a page is relevant to their search. ' + - '[Learn more about document titles](https://dequeuniversity.com/rules/axe/4.4/document-title).', + '[Learn more about document titles](https://dequeuniversity.com/rules/axe/4.6/document-title).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/duplicate-id-active.js b/core/audits/accessibility/duplicate-id-active.js index c09ddc9a4736..fa680182430b 100644 --- a/core/audits/accessibility/duplicate-id-active.js +++ b/core/audits/accessibility/duplicate-id-active.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accesibility audit that checks if there are any duplicate id HTML attributes on active, focusable elements. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: '`[id]` attributes on active, focusable elements are not unique', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'All focusable elements must have a unique `id` to ensure that they\'re visible to assistive technologies. [Learn how to fix duplicate `id`s](https://dequeuniversity.com/rules/axe/4.4/duplicate-id-active).', + description: 'All focusable elements must have a unique `id` to ensure that they\'re visible to assistive technologies. [Learn how to fix duplicate `id`s](https://dequeuniversity.com/rules/axe/4.6/duplicate-id-active).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/duplicate-id-aria.js b/core/audits/accessibility/duplicate-id-aria.js index c91ad691e277..9ec843cf75e5 100644 --- a/core/audits/accessibility/duplicate-id-aria.js +++ b/core/audits/accessibility/duplicate-id-aria.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accesibility audit that checks if there are any duplicate ARIA IDs on the page. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'ARIA IDs are not unique', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'The value of an ARIA ID must be unique to prevent other instances from being overlooked by assistive technologies. [Learn how to fix duplicate ARIA IDs](https://dequeuniversity.com/rules/axe/4.4/duplicate-id-aria).', + description: 'The value of an ARIA ID must be unique to prevent other instances from being overlooked by assistive technologies. [Learn how to fix duplicate ARIA IDs](https://dequeuniversity.com/rules/axe/4.6/duplicate-id-aria).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/form-field-multiple-labels.js b/core/audits/accessibility/form-field-multiple-labels.js index ea76e1586fc4..f23ac24b5f21 100644 --- a/core/audits/accessibility/form-field-multiple-labels.js +++ b/core/audits/accessibility/form-field-multiple-labels.js @@ -18,7 +18,7 @@ const UIStrings = { /** Title of an accesibility audit that checks if any form fields have multiple label elements. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */ failureTitle: 'Form fields have multiple labels', /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */ - description: 'Form fields with multiple labels can be confusingly announced by assistive technologies like screen readers which use either the first, the last, or all of the labels. [Learn how to use form labels](https://dequeuniversity.com/rules/axe/4.4/form-field-multiple-labels).', + description: 'Form fields with multiple labels can be confusingly announced by assistive technologies like screen readers which use either the first, the last, or all of the labels. [Learn how to use form labels](https://dequeuniversity.com/rules/axe/4.6/form-field-multiple-labels).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); diff --git a/core/audits/accessibility/frame-title.js b/core/audits/accessibility/frame-title.js index bcb6e2e059f7..38c08d6a7c7b 100644 --- a/core/audits/accessibility/frame-title.js +++ b/core/audits/accessibility/frame-title.js @@ -19,7 +19,7 @@ const UIStrings = { failureTitle: '`` or `