From 12dd8672f0faf7e4e6940693022be59d363f5147 Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Mon, 27 Nov 2023 12:07:21 -0500 Subject: [PATCH 1/2] core(aria-allowed-role): fix typo in learn more link --- core/audits/accessibility/aria-allowed-role.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/audits/accessibility/aria-allowed-role.js b/core/audits/accessibility/aria-allowed-role.js index 13e97a69f0c2..39e975cc8d5a 100644 --- a/core/audits/accessibility/aria-allowed-role.js +++ b/core/audits/accessibility/aria-allowed-role.js @@ -22,7 +22,7 @@ const UIStrings = { 'the web page. If the `role` values are misspelled, not existing ARIA `role` values, or ' + 'abstract roles, then the purpose of the element will not be communicated to users of ' + 'assistive technologies. ' + - '[Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-roles).', + '[Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-role).', }; const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); From 4b06df7d21aac0e4ce8b35ee37d9f57d5080a1b7 Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Mon, 27 Nov 2023 17:03:03 -0500 Subject: [PATCH 2/2] sample --- .../fixtures/user-flows/reports/sample-flow-result.json | 6 +++--- core/test/results/sample_v2.json | 2 +- shared/localization/locales/en-US.json | 2 +- shared/localization/locales/en-XL.json | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/core/test/fixtures/user-flows/reports/sample-flow-result.json b/core/test/fixtures/user-flows/reports/sample-flow-result.json index 7fa1b54128fc..3db291ad8ae6 100644 --- a/core/test/fixtures/user-flows/reports/sample-flow-result.json +++ b/core/test/fixtures/user-flows/reports/sample-flow-result.json @@ -2139,7 +2139,7 @@ "aria-allowed-role": { "id": "aria-allowed-role", "title": "Values assigned to `role=\"\"` are valid ARIA roles.", - "description": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-roles).", + "description": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-role).", "score": 1, "scoreDisplayMode": "binary", "details": { @@ -12650,7 +12650,7 @@ "aria-allowed-role": { "id": "aria-allowed-role", "title": "Values assigned to `role=\"\"` are valid ARIA roles.", - "description": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-roles).", + "description": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-role).", "score": 1, "scoreDisplayMode": "binary", "details": { @@ -19603,7 +19603,7 @@ "aria-allowed-role": { "id": "aria-allowed-role", "title": "Values assigned to `role=\"\"` are valid ARIA roles.", - "description": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-roles).", + "description": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-role).", "score": 1, "scoreDisplayMode": "binary", "details": { diff --git a/core/test/results/sample_v2.json b/core/test/results/sample_v2.json index ed08b43588a6..575dff892112 100644 --- a/core/test/results/sample_v2.json +++ b/core/test/results/sample_v2.json @@ -3016,7 +3016,7 @@ "aria-allowed-role": { "id": "aria-allowed-role", "title": "Values assigned to `role=\"\"` are valid ARIA roles.", - "description": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-roles).", + "description": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-role).", "score": 1, "scoreDisplayMode": "binary", "details": { diff --git a/shared/localization/locales/en-US.json b/shared/localization/locales/en-US.json index 5c46889f1a06..b31c2b40b6af 100644 --- a/shared/localization/locales/en-US.json +++ b/shared/localization/locales/en-US.json @@ -18,7 +18,7 @@ "message": "`[aria-*]` attributes match their roles" }, "core/audits/accessibility/aria-allowed-role.js | description": { - "message": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-roles)." + "message": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-role)." }, "core/audits/accessibility/aria-allowed-role.js | failureTitle": { "message": "Values assigned to `role=\"\"` are not valid ARIA roles." diff --git a/shared/localization/locales/en-XL.json b/shared/localization/locales/en-XL.json index aa21a2054b59..2225b11e1c90 100644 --- a/shared/localization/locales/en-XL.json +++ b/shared/localization/locales/en-XL.json @@ -18,7 +18,7 @@ "message": "`[aria-*]` ât́t̂ŕîb́ût́êś m̂át̂ćĥ t́ĥéîŕ r̂ól̂éŝ" }, "core/audits/accessibility/aria-allowed-role.js | description": { - "message": "ÂŔÎÁ `role`ŝ én̂áb̂ĺê áŝśîśt̂ív̂é t̂éĉh́n̂ól̂óĝíêś t̂ó k̂ńôẃ t̂h́ê ŕôĺê óf̂ éâćĥ él̂ém̂én̂t́ ôń t̂h́ê ẃêb́ p̂áĝé. Îf́ t̂h́ê `role` v́âĺûéŝ ár̂é m̂íŝśp̂él̂ĺêd́, n̂ót̂ éx̂íŝt́îńĝ ÁR̂ÍÂ `role` v́âĺûéŝ, ór̂ áb̂śt̂ŕâćt̂ ŕôĺêś, t̂h́êń t̂h́ê ṕûŕp̂óŝé ôf́ t̂h́ê él̂ém̂én̂t́ ŵíl̂ĺ n̂ót̂ b́ê ćôḿm̂ún̂íĉát̂éd̂ t́ô úŝér̂ś ôf́ âśŝíŝt́îv́ê t́êćĥńôĺôǵîéŝ. [Ĺêár̂ń m̂ór̂é âb́ôút̂ ÁR̂ÍÂ ŕôĺêś](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-roles)." + "message": "ÂŔÎÁ `role`ŝ én̂áb̂ĺê áŝśîśt̂ív̂é t̂éĉh́n̂ól̂óĝíêś t̂ó k̂ńôẃ t̂h́ê ŕôĺê óf̂ éâćĥ él̂ém̂én̂t́ ôń t̂h́ê ẃêb́ p̂áĝé. Îf́ t̂h́ê `role` v́âĺûéŝ ár̂é m̂íŝśp̂él̂ĺêd́, n̂ót̂ éx̂íŝt́îńĝ ÁR̂ÍÂ `role` v́âĺûéŝ, ór̂ áb̂śt̂ŕâćt̂ ŕôĺêś, t̂h́êń t̂h́ê ṕûŕp̂óŝé ôf́ t̂h́ê él̂ém̂én̂t́ ŵíl̂ĺ n̂ót̂ b́ê ćôḿm̂ún̂íĉát̂éd̂ t́ô úŝér̂ś ôf́ âśŝíŝt́îv́ê t́êćĥńôĺôǵîéŝ. [Ĺêár̂ń m̂ór̂é âb́ôút̂ ÁR̂ÍÂ ŕôĺêś](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-role)." }, "core/audits/accessibility/aria-allowed-role.js | failureTitle": { "message": "V̂ál̂úêś âśŝíĝńêd́ t̂ó `role=\"\"` âŕê ńôt́ v̂ál̂íd̂ ÁR̂ÍÂ ŕôĺêś."