From 1e5b00e06bf36238e22fc74253e159734bd3c140 Mon Sep 17 00:00:00 2001 From: Adam Raine <6752989+adamraine@users.noreply.github.com> Date: Mon, 5 Feb 2024 09:37:16 -0800 Subject: [PATCH 1/6] Revert "tests(dbw): update expectations for unload handler removal (#15765)" This reverts commit 3d27df19160a60f3a1c0dcf26f0563f7ed786f5f. --- .../test-definitions/dobetterweb.js | 21 +++---------------- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/cli/test/smokehouse/test-definitions/dobetterweb.js b/cli/test/smokehouse/test-definitions/dobetterweb.js index 4e56ee67c940..1c965fa485ee 100644 --- a/cli/test/smokehouse/test-definitions/dobetterweb.js +++ b/cli/test/smokehouse/test-definitions/dobetterweb.js @@ -208,8 +208,6 @@ const expectations = { }, ], GlobalListeners: [{ - // Unload handlers were disabled in M122 - _maxChromiumVersion: '121', type: 'unload', scriptId: /^\d+$/, lineNumber: '>300', @@ -308,13 +306,6 @@ const expectations = { description: 'Failed to load resource: the server responded with a status of 404 (Not Found)', sourceLocation: {url: 'http://localhost:10200/favicon.ico'}, }, - { - // Unload handlers were disabled in M122 - _minChromiumVersion: '122', - source: 'violation', - description: 'Permissions policy violation: unload is not allowed in this document.', - sourceLocation: {url: 'http://localhost:10200/dobetterweb/dbw_tester.html'}, - }, ], }, }, @@ -387,10 +378,7 @@ const expectations = { subItems: undefined, }, { - // Deprecation warning was added in M121 _minChromiumVersion: '121', - // Unload handlers were disabled in M122 - _maxChromiumVersion: '121', value: 'UnloadHandler', source: { type: 'source-location', @@ -492,8 +480,6 @@ const expectations = { }, }, 'no-unload-listeners': { - // Unload handlers were disabled in M122 - _maxChromiumVersion: '121', score: 0, details: { items: [{ @@ -511,8 +497,6 @@ const expectations = { details: { items: [ { - // Unload handlers were disabled in M122 - _maxChromiumVersion: '121', reason: 'The page has an unload handler in the main frame.', failureType: 'Actionable', subItems: { @@ -522,8 +506,9 @@ const expectations = { }, }, { - // Unload handlers create a permission request in M122 - _minChromiumVersion: '122', + // This issue only appears in the DevTools runner for some reason. + // TODO: Investigate why this doesn't happen on the CLI runner. + _runner: 'devtools', reason: 'There were permission requests upon navigating away.', failureType: 'Pending browser support', subItems: { From 870c40a975e7a0df76af1057a04ac1bfe7480667 Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Mon, 5 Feb 2024 10:00:44 -0800 Subject: [PATCH 2/6] oopif scripts --- cli/test/smokehouse/test-definitions/oopif-scripts.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cli/test/smokehouse/test-definitions/oopif-scripts.js b/cli/test/smokehouse/test-definitions/oopif-scripts.js index 4f4f6c88ab4f..5c3d2b401240 100644 --- a/cli/test/smokehouse/test-definitions/oopif-scripts.js +++ b/cli/test/smokehouse/test-definitions/oopif-scripts.js @@ -107,14 +107,14 @@ const expectations = { source: 'network', }, { - // Worker requests emitted on the worker's parent target since M121. - _minChromiumVersion: '121', + // Worker requests emitted on the worker's parent target since M123. + _minChromiumVersion: '123', src: 'http://localhost:10200/simple-worker.mjs', source: 'network', }, { - // Worker requests emitted on the worker's parent target since M121. - _minChromiumVersion: '121', + // Worker requests emitted on the worker's parent target since M123. + _minChromiumVersion: '123', src: 'http://localhost:10200/simple-worker.js', source: 'network', }, From fbe8cf6c3eb35dcccdf308284285433293a6c856 Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Mon, 5 Feb 2024 10:11:19 -0800 Subject: [PATCH 3/6] deps: upgrade puppeteer to 22.0.0 --- core/scripts/benchmark-plus-extras.js | 4 +- core/scripts/update-flow-fixtures.js | 2 +- core/test/scenarios/api-test-pptr.js | 4 +- core/test/scenarios/pptr-test-utils.js | 1 - flow-report/test/flow-report-pptr-test.ts | 1 - package.json | 4 +- types/internal/rxjs.d.ts | 2 + yarn.lock | 71 ++++++++++++----------- 8 files changed, 47 insertions(+), 42 deletions(-) diff --git a/core/scripts/benchmark-plus-extras.js b/core/scripts/benchmark-plus-extras.js index df0f023f414d..c1c4834dbf6a 100644 --- a/core/scripts/benchmark-plus-extras.js +++ b/core/scripts/benchmark-plus-extras.js @@ -24,7 +24,7 @@ async function runOctane(page) { process.stdout.write(`Running Octane...\n`); await page.goto('https://chromium.github.io/octane/', {waitUntil: 'networkidle0'}); await page.waitForSelector('#run-octane'); - await page.waitForTimeout(5000); + await new Promise(r => setTimeout(r, 5000)); page.on('console', pageLogger); await page.click('#run-octane'); await page.waitForFunction(() => { @@ -48,7 +48,7 @@ async function runSpeedometer(page) { process.stdout.write(`Running Speedometer...\n`); await page.goto('https://browserbench.org/Speedometer2.0/', {waitUntil: 'networkidle0'}); await page.waitForSelector('#home button'); - await page.waitForTimeout(5000); + await new Promise(r => setTimeout(r, 5000)); await page.click('#home button'); const loggerInterval = setInterval(async () => { diff --git a/core/scripts/update-flow-fixtures.js b/core/scripts/update-flow-fixtures.js index 1b84df68174b..d3d91210e4ca 100644 --- a/core/scripts/update-flow-fixtures.js +++ b/core/scripts/update-flow-fixtures.js @@ -66,7 +66,7 @@ async function waitForImagesToLoad(page) { assert.deepStrictEqual(completeImages, firstRunImages); // Next check we haven't added any new images in the quiet window. - await page.waitForTimeout(QUIET_WINDOW); + await new Promise(r => setTimeout(r, QUIET_WINDOW)); const secondRunImages = await getImageLoadingStates(); assert.deepStrictEqual(secondRunImages, firstRunImages); }, TIMEOUT); diff --git a/core/test/scenarios/api-test-pptr.js b/core/test/scenarios/api-test-pptr.js index c812e0389e27..09003027e56e 100644 --- a/core/test/scenarios/api-test-pptr.js +++ b/core/test/scenarios/api-test-pptr.js @@ -76,7 +76,7 @@ describe('Individual modes API', function() { await setupTestPage(); // Wait long enough to ensure a paint after button interaction. - await state.page.waitForTimeout(200); + await new Promise(r => setTimeout(r, 200)); const result = await run.endTimespan(); if (!result) throw new Error('Lighthouse failed to produce a result'); @@ -139,7 +139,7 @@ describe('Individual modes API', function() { await page.waitForSelector('input'); // Wait long enough to ensure a paint after button interaction. - await page.waitForTimeout(200); + await new Promise(r => setTimeout(r, 200)); const result = await run.endTimespan(); diff --git a/core/test/scenarios/pptr-test-utils.js b/core/test/scenarios/pptr-test-utils.js index 6140b68a1e24..8e75ae17a8d1 100644 --- a/core/test/scenarios/pptr-test-utils.js +++ b/core/test/scenarios/pptr-test-utils.js @@ -56,7 +56,6 @@ function createTestState() { before(async () => { this.browser = await puppeteer.launch({ - headless: 'new', executablePath: getChromePath(), ignoreDefaultArgs: ['--enable-automation'], }); diff --git a/flow-report/test/flow-report-pptr-test.ts b/flow-report/test/flow-report-pptr-test.ts index 2690da23d15d..adea706a6dc6 100644 --- a/flow-report/test/flow-report-pptr-test.ts +++ b/flow-report/test/flow-report-pptr-test.ts @@ -20,7 +20,6 @@ describe('Lighthouse Flow Report', () => { before(async () => { browser = await puppeteer.launch({ - headless: 'new', executablePath: getChromePath(), }); page = await browser.newPage(); diff --git a/package.json b/package.json index 8430497063b9..243858cf6ad7 100644 --- a/package.json +++ b/package.json @@ -166,7 +166,7 @@ "pako": "^2.0.3", "preact": "^10.7.2", "pretty-json-stringify": "^0.0.2", - "puppeteer": "^21.7.0", + "puppeteer": "^22.0.0", "resolve": "^1.22.1", "rollup": "^2.52.7", "rollup-plugin-polyfill-node": "^0.12.0", @@ -200,7 +200,7 @@ "open": "^8.4.0", "parse-cache-control": "1.0.1", "ps-list": "^8.0.0", - "puppeteer-core": "^21.7.0", + "puppeteer-core": "^22.0.0", "robots-parser": "^3.0.1", "semver": "^5.3.0", "speedline-core": "^1.4.3", diff --git a/types/internal/rxjs.d.ts b/types/internal/rxjs.d.ts index b493b9e45ab5..bd579adf0baa 100644 --- a/types/internal/rxjs.d.ts +++ b/types/internal/rxjs.d.ts @@ -17,6 +17,7 @@ declare module 'rxjs' { export const ignoreElements: any; export const map: any; export const mergeMap: any; + export const mergeScan: any; export const raceWith: any; export const retry: any; export const tap: any; @@ -25,6 +26,7 @@ declare module 'rxjs' { export const delay: any; export const startWith: any; export const switchMap: any; + export const take: any; export const bufferCount: any; export const concatMap: any; export const lastValueFrom: any; diff --git a/yarn.lock b/yarn.lock index bcd4da02d70a..d00c9ffdeba1 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1138,10 +1138,10 @@ resolved "https://registry.yarnpkg.com/@protobufjs/utf8/-/utf8-1.1.0.tgz#a777360b5b39a1a2e5106f8e858f2fd2d060c570" integrity sha1-p3c2C1s5oaLlEG+OhY8v0tBgxXA= -"@puppeteer/browsers@1.9.1": - version "1.9.1" - resolved "https://registry.yarnpkg.com/@puppeteer/browsers/-/browsers-1.9.1.tgz#384ee8b09786f0e8f62b1925e4c492424cb549ee" - integrity sha512-PuvK6xZzGhKPvlx3fpfdM2kYY3P/hB1URtK8wA7XUJ6prn6pp22zvJHu48th0SGcHL9SutbPHrFuQgfXTFobWA== +"@puppeteer/browsers@2.0.0": + version "2.0.0" + resolved "https://registry.yarnpkg.com/@puppeteer/browsers/-/browsers-2.0.0.tgz#3646d2a465c112eac21510d43b21c828612118f9" + integrity sha512-3PS82/5+tnpEaUWonjAFFvlf35QHF15xqyGd34GBa5oP5EPVfFXRsbSxIGYf1M+vZlqBZ3oxT1kRg9OYhtt8ng== dependencies: debug "4.3.4" extract-zip "2.0.1" @@ -2333,13 +2333,13 @@ chrome-launcher@^1.1.0: is-wsl "^2.2.0" lighthouse-logger "^2.0.1" -chromium-bidi@0.5.2: - version "0.5.2" - resolved "https://registry.yarnpkg.com/chromium-bidi/-/chromium-bidi-0.5.2.tgz#358b03bb7c53e0f8d0fd77d596ea67ee30f7ff06" - integrity sha512-PbVOSddxgKyj+JByqavWMNqWPCoCaT6XK5Z1EFe168sxnB/BM51LnZEPXSbFcFAJv/+u2B4XNTs9uXxy4GW3cQ== +chromium-bidi@0.5.8: + version "0.5.8" + resolved "https://registry.yarnpkg.com/chromium-bidi/-/chromium-bidi-0.5.8.tgz#5053038425c062ed34b9bc973e84e79de0a5cef0" + integrity sha512-blqh+1cEQbHBKmok3rVJkBlBxt9beKBgOsxbFgs7UJcoVbbeZ+K7+6liAsjgpc8l1Xd55cQUy14fXZdGSb4zIw== dependencies: mitt "3.0.1" - urlpattern-polyfill "9.0.0" + urlpattern-polyfill "10.0.0" ci-info@^3.2.0: version "3.3.1" @@ -2668,15 +2668,15 @@ core-util-is@1.0.2, core-util-is@~1.0.0: resolved "https://registry.yarnpkg.com/core-util-is/-/core-util-is-1.0.2.tgz#b5fd54220aa2bc5ab57aab7140c940754503c1a7" integrity sha1-tf1UIgqivFq1eqtxQMlAdUUDwac= -cosmiconfig@8.3.6: - version "8.3.6" - resolved "https://registry.yarnpkg.com/cosmiconfig/-/cosmiconfig-8.3.6.tgz#060a2b871d66dba6c8538ea1118ba1ac16f5fae3" - integrity sha512-kcZ6+W5QzcJ3P1Mt+83OUv/oHFqZHIx8DuxG6eZ5RGMERoLqp4BuGjhHLYGK+Kf5XVkQvqBSmAy/nGWN3qDgEA== +cosmiconfig@9.0.0: + version "9.0.0" + resolved "https://registry.yarnpkg.com/cosmiconfig/-/cosmiconfig-9.0.0.tgz#34c3fc58287b915f3ae905ab6dc3de258b55ad9d" + integrity sha512-itvL5h8RETACmOTFc4UfIyB2RfEHi71Ax6E/PivVxq9NseKbOWpeyHEOIbmAw1rs8Ak0VursQNww7lf7YtUwzg== dependencies: + env-paths "^2.2.1" import-fresh "^3.3.0" js-yaml "^4.1.0" parse-json "^5.2.0" - path-type "^4.0.0" cosmiconfig@^5.1.0: version "5.2.1" @@ -2921,7 +2921,7 @@ delayed-stream@~1.0.0: resolved "https://registry.yarnpkg.com/delayed-stream/-/delayed-stream-1.0.0.tgz#df3ae199acadfb7d440aaae0b29e2272b24ec619" integrity sha1-3zrhmayt+31ECqrgsp4icrJOxhk= -devtools-protocol@0.0.1203626, devtools-protocol@0.0.1211954: +devtools-protocol@0.0.1211954, devtools-protocol@0.0.1232444: version "0.0.1211954" resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.1211954.tgz#86ea77d011baab619fb096fc426fd8633ad2ef9b" integrity sha512-f6BRhngr9wpHN8omZOoSaEJFscTL+tjNhmeBqHHC3CZ3K2N75sDeKXZeTkAEkTCcrusDatfwjRRBh0uz4ov/sA== @@ -3024,6 +3024,11 @@ enquirer@^2.3.5, enquirer@^2.3.6: dependencies: ansi-colors "^4.1.1" +env-paths@^2.2.1: + version "2.2.1" + resolved "https://registry.yarnpkg.com/env-paths/-/env-paths-2.2.1.tgz#420399d416ce1fbe9bc0a07c62fa68d67fd0f8f2" + integrity sha512-+h1lkLKhZMTYjog1VEpJNG7NZJWcuc2DDk/qsqSTRRCOXiLjeQ1d1/udrUGhqMxUgAlwKNZ0cf2uqan5GLuS2A== + error-ex@^1.3.1: version "1.3.2" resolved "https://registry.yarnpkg.com/error-ex/-/error-ex-1.3.2.tgz#b4ac40648107fdcdcfae242f428bea8a14d4f1bf" @@ -6029,26 +6034,26 @@ punycode@^2.1.0, punycode@^2.1.1: resolved "https://registry.yarnpkg.com/punycode/-/punycode-2.1.1.tgz#b58b010ac40c22c5657616c8d2c2c02c7bf479ec" integrity sha512-XRsRjdf+j5ml+y/6GKHPZbrF/8p2Yga0JPtdqTIY2Xe5ohJPD9saDJJLPvp9+NSBprVvevdXZybnj2cv8OEd0A== -puppeteer-core@21.7.0, puppeteer-core@^21.7.0: - version "21.7.0" - resolved "https://registry.yarnpkg.com/puppeteer-core/-/puppeteer-core-21.7.0.tgz#c0abb98cbd17dbd7ee317b4257958337fa25d2c7" - integrity sha512-elPYPozrgiM3phSy7VDUJCVWQ07SPnOm78fpSaaSNFoQx5sur/MqhTSro9Wz8lOEjqCykGC6WRkwxDgmqcy1dQ== +puppeteer-core@22.0.0, puppeteer-core@^22.0.0: + version "22.0.0" + resolved "https://registry.yarnpkg.com/puppeteer-core/-/puppeteer-core-22.0.0.tgz#f46420adac6f7be076a1f7a751c8d829461b55d2" + integrity sha512-S3s91rLde0A86PWVeNY82h+P0fdS7CTiNWAicCVH/bIspRP4nS2PnO5j+VTFqCah0ZJizGzpVPAmxVYbLxTc9w== dependencies: - "@puppeteer/browsers" "1.9.1" - chromium-bidi "0.5.2" + "@puppeteer/browsers" "2.0.0" + chromium-bidi "0.5.8" cross-fetch "4.0.0" debug "4.3.4" - devtools-protocol "0.0.1203626" + devtools-protocol "0.0.1232444" ws "8.16.0" -puppeteer@^21.7.0: - version "21.7.0" - resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-21.7.0.tgz#c4b46ef28a2986f9c536eb086ab47c8dea80e4f9" - integrity sha512-Yy+UUy0b9siJezbhHO/heYUoZQUwyqDK1yOQgblTt0l97tspvDVFkcW9toBlnSvSfkDmMI3Dx9cZL6R8bDArHA== +puppeteer@^22.0.0: + version "22.0.0" + resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-22.0.0.tgz#e2eb456c667ffb165079f4fb0b6936dd6c9ccf36" + integrity sha512-zYVnjwJngnSB4dbkWp7DHFSIc3nqHvZzrdHyo9+ugV1nq1Lm8obOMcmCFaGfR3PJs0EmYNz+/skBeO45yvASCQ== dependencies: - "@puppeteer/browsers" "1.9.1" - cosmiconfig "8.3.6" - puppeteer-core "21.7.0" + "@puppeteer/browsers" "2.0.0" + cosmiconfig "9.0.0" + puppeteer-core "22.0.0" q@^1.5.1: version "1.5.1" @@ -7217,10 +7222,10 @@ urix@^0.1.0: resolved "https://registry.yarnpkg.com/urix/-/urix-0.1.0.tgz#da937f7a62e21fec1fd18d49b35c2935067a6c72" integrity sha1-2pN/emLiH+wf0Y1Js1wpNQZ6bHI= -urlpattern-polyfill@9.0.0: - version "9.0.0" - resolved "https://registry.yarnpkg.com/urlpattern-polyfill/-/urlpattern-polyfill-9.0.0.tgz#bc7e386bb12fd7898b58d1509df21d3c29ab3460" - integrity sha512-WHN8KDQblxd32odxeIgo83rdVDE2bvdkb86it7bMhYZwWKJz0+O0RK/eZiHYnM+zgt/U7hAHOlCQGfjjvSkw2g== +urlpattern-polyfill@10.0.0: + version "10.0.0" + resolved "https://registry.yarnpkg.com/urlpattern-polyfill/-/urlpattern-polyfill-10.0.0.tgz#f0a03a97bfb03cdf33553e5e79a2aadd22cac8ec" + integrity sha512-H/A06tKD7sS1O1X2SshBVeA5FLycRpjqiBeqGKmBwBDBy28EnRjORxTNe269KSSr5un5qyWi1iL61wLxpd+ZOg== use@^3.1.0: version "3.1.0" From 5a203d9be774503a6787cc675acf3425770fe0e9 Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Mon, 5 Feb 2024 10:22:32 -0800 Subject: [PATCH 4/6] rm new headless --- clients/test/extension/popup-test-pptr.js | 1 - core/test/gather/gatherers/accessibility-test.js | 1 - report/test/renderer/report-renderer-axe-test.js | 1 - viewer/test/viewer-test-pptr.js | 1 - 4 files changed, 4 deletions(-) diff --git a/clients/test/extension/popup-test-pptr.js b/clients/test/extension/popup-test-pptr.js index f75a6326bae9..be99df387515 100644 --- a/clients/test/extension/popup-test-pptr.js +++ b/clients/test/extension/popup-test-pptr.js @@ -51,7 +51,6 @@ describe('Lighthouse chrome popup', function() { before(async function() { // start puppeteer browser = await puppeteer.launch({ - headless: 'new', executablePath: getChromePath(), }); diff --git a/core/test/gather/gatherers/accessibility-test.js b/core/test/gather/gatherers/accessibility-test.js index a8e9f994e0b6..4a6149fcf756 100644 --- a/core/test/gather/gatherers/accessibility-test.js +++ b/core/test/gather/gatherers/accessibility-test.js @@ -43,7 +43,6 @@ describe('a11y audits + aXe', () => { before(async () => { browser = await puppeteer.launch({ - headless: 'new', executablePath: getChromePath(), }); }); diff --git a/report/test/renderer/report-renderer-axe-test.js b/report/test/renderer/report-renderer-axe-test.js index 3fa1f18ea63f..e20c8be9f150 100644 --- a/report/test/renderer/report-renderer-axe-test.js +++ b/report/test/renderer/report-renderer-axe-test.js @@ -19,7 +19,6 @@ describe('ReportRendererAxe', () => { before(async () => { browser = await puppeteer.launch({ - headless: 'new', executablePath: getChromePath(), }); }); diff --git a/viewer/test/viewer-test-pptr.js b/viewer/test/viewer-test-pptr.js index 8947f0e8317d..e7049827fb36 100644 --- a/viewer/test/viewer-test-pptr.js +++ b/viewer/test/viewer-test-pptr.js @@ -67,7 +67,6 @@ describe('Lighthouse Viewer', () => { // start puppeteer browser = await puppeteer.launch({ - headless: 'new', executablePath: getChromePath(), }); viewerPage = await browser.newPage(); From fefae33e4ccb3138bad8ffec039da52789f35bff Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Tue, 6 Feb 2024 11:04:26 -0800 Subject: [PATCH 5/6] double raf --- core/test/scenarios/api-test-pptr.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/core/test/scenarios/api-test-pptr.js b/core/test/scenarios/api-test-pptr.js index 09003027e56e..b8bc0001060a 100644 --- a/core/test/scenarios/api-test-pptr.js +++ b/core/test/scenarios/api-test-pptr.js @@ -11,6 +11,8 @@ import {createTestState, getAuditsBreakdown} from './pptr-test-utils.js'; import {LH_ROOT} from '../../../shared/root.js'; import {TargetManager} from '../../gather/driver/target-manager.js'; +const doubleRaf = 'new Promise(r => requestAnimationFrame(() => requestAnimationFrame(r)))'; + describe('Individual modes API', function() { // eslint-disable-next-line no-invalid-this this.timeout(120_000); @@ -76,7 +78,7 @@ describe('Individual modes API', function() { await setupTestPage(); // Wait long enough to ensure a paint after button interaction. - await new Promise(r => setTimeout(r, 200)); + await state.page.evaluate(doubleRaf); const result = await run.endTimespan(); if (!result) throw new Error('Lighthouse failed to produce a result'); @@ -136,10 +138,10 @@ describe('Individual modes API', function() { const run = await api.startTimespan(state.page); await page.click('button'); - await page.waitForSelector('input'); + await page.waitForSelector('input', {}); // Wait long enough to ensure a paint after button interaction. - await new Promise(r => setTimeout(r, 200)); + await page.evaluate(doubleRaf); const result = await run.endTimespan(); From 8a7e0f9d936df0d20fe1aef9c23ffff164df7098 Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Tue, 6 Feb 2024 11:07:18 -0800 Subject: [PATCH 6/6] ope --- core/test/scenarios/api-test-pptr.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/test/scenarios/api-test-pptr.js b/core/test/scenarios/api-test-pptr.js index b8bc0001060a..0004bef222ac 100644 --- a/core/test/scenarios/api-test-pptr.js +++ b/core/test/scenarios/api-test-pptr.js @@ -138,7 +138,7 @@ describe('Individual modes API', function() { const run = await api.startTimespan(state.page); await page.click('button'); - await page.waitForSelector('input', {}); + await page.waitForSelector('input'); // Wait long enough to ensure a paint after button interaction. await page.evaluate(doubleRaf);