From 8aa2153096359f3a98d45b47ef0f5c651491b6dd Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Mon, 13 May 2024 10:15:50 -0700 Subject: [PATCH] core(inspector-issues): add shared dictionary issue --- core/gather/gatherers/inspector-issues.js | 1 + core/test/gather/gatherers/inspector-issues-test.js | 2 ++ package.json | 6 +++--- .../inspector-issueAdded-types-test.js | 1 + types/artifacts.d.ts | 1 + yarn.lock | 8 ++++---- 6 files changed, 12 insertions(+), 7 deletions(-) diff --git a/core/gather/gatherers/inspector-issues.js b/core/gather/gatherers/inspector-issues.js index 9b7631f0aadf..8f4d949c979b 100644 --- a/core/gather/gatherers/inspector-issues.js +++ b/core/gather/gatherers/inspector-issues.js @@ -80,6 +80,7 @@ class InspectorIssues extends BaseGatherer { quirksModeIssue: [], cookieIssue: [], sharedArrayBufferIssue: [], + sharedDictionaryIssue: [], stylesheetLoadingIssue: [], federatedAuthUserInfoRequestIssue: [], }; diff --git a/core/test/gather/gatherers/inspector-issues-test.js b/core/test/gather/gatherers/inspector-issues-test.js index eb69793df3d7..562363977dc6 100644 --- a/core/test/gather/gatherers/inspector-issues-test.js +++ b/core/test/gather/gatherers/inspector-issues-test.js @@ -250,6 +250,7 @@ describe('getArtifact', () => { propertyRuleIssue: [], quirksModeIssue: [], sharedArrayBufferIssue: [], + sharedDictionaryIssue: [], federatedAuthRequestIssue: [], stylesheetLoadingIssue: [], federatedAuthUserInfoRequestIssue: [], @@ -315,6 +316,7 @@ describe('getArtifact', () => { propertyRuleIssue: [], quirksModeIssue: [], sharedArrayBufferIssue: [], + sharedDictionaryIssue: [], federatedAuthRequestIssue: [], stylesheetLoadingIssue: [], federatedAuthUserInfoRequestIssue: [], diff --git a/package.json b/package.json index 154e9e06c55a..d3c92381af13 100644 --- a/package.json +++ b/package.json @@ -185,7 +185,7 @@ "chrome-launcher": "^1.1.1", "configstore": "^5.0.1", "csp_evaluator": "1.1.1", - "devtools-protocol": "0.0.1232444", + "devtools-protocol": "0.0.1299070", "enquirer": "^2.3.6", "http-link-header": "^1.1.1", "intl-messageformat": "^10.5.3", @@ -210,8 +210,8 @@ "yargs-parser": "^21.0.0" }, "resolutions": { - "puppeteer/**/devtools-protocol": "0.0.1232444", - "puppeteer-core/**/devtools-protocol": "0.0.1232444" + "puppeteer/**/devtools-protocol": "0.0.1299070", + "puppeteer-core/**/devtools-protocol": "0.0.1299070" }, "repository": "GoogleChrome/lighthouse", "keywords": [ diff --git a/third-party/chromium-synchronization/inspector-issueAdded-types-test.js b/third-party/chromium-synchronization/inspector-issueAdded-types-test.js index 70f07fd0cb0b..be9934e4966c 100644 --- a/third-party/chromium-synchronization/inspector-issueAdded-types-test.js +++ b/third-party/chromium-synchronization/inspector-issueAdded-types-test.js @@ -51,6 +51,7 @@ Array [ "propertyRuleIssueDetails", "quirksModeIssueDetails", "sharedArrayBufferIssueDetails", + "sharedDictionaryIssueDetails", "stylesheetLoadingIssueDetails", ] `); diff --git a/types/artifacts.d.ts b/types/artifacts.d.ts index fa1e6f13ab1b..9126d5928b8e 100644 --- a/types/artifacts.d.ts +++ b/types/artifacts.d.ts @@ -545,6 +545,7 @@ declare module Artifacts { quirksModeIssue: Crdp.Audits.QuirksModeIssueDetails[]; cookieIssue: Crdp.Audits.CookieIssueDetails[]; sharedArrayBufferIssue: Crdp.Audits.SharedArrayBufferIssueDetails[]; + sharedDictionaryIssue: Crdp.Audits.SharedDictionaryIssueDetails[]; stylesheetLoadingIssue: Crdp.Audits.StylesheetLoadingIssueDetails[]; federatedAuthUserInfoRequestIssue: Crdp.Audits.FederatedAuthUserInfoRequestIssueDetails[]; } diff --git a/yarn.lock b/yarn.lock index 47636d93851f..11eb4ccfc068 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2938,10 +2938,10 @@ delayed-stream@~1.0.0: resolved "https://registry.yarnpkg.com/delayed-stream/-/delayed-stream-1.0.0.tgz#df3ae199acadfb7d440aaae0b29e2272b24ec619" integrity sha1-3zrhmayt+31ECqrgsp4icrJOxhk= -devtools-protocol@0.0.1232444, devtools-protocol@0.0.1262051: - version "0.0.1232444" - resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.1232444.tgz#406345a90a871ba852c530d73482275234936eed" - integrity sha512-pM27vqEfxSxRkTMnF+XCmxSEb6duO5R+t8A9DEEJgy4Wz2RVanje2mmj99B6A3zv2r/qGfYlOvYznUhuokizmg== +devtools-protocol@0.0.1262051, devtools-protocol@0.0.1299070: + version "0.0.1299070" + resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.1299070.tgz#b3e4cf0b678a46f0f907ae6e07e03ad3a53c00df" + integrity sha512-+qtL3eX50qsJ7c+qVyagqi7AWMoQCBGNfoyJZMwm/NSXVqLYbuitrWEEIzxfUmTNy7//Xe8yhMmQ+elj3uAqSg== diff-sequences@^28.0.2: version "28.0.2"