From 8e44a1fc752cc39f32d7ee07f66e7b25997307e1 Mon Sep 17 00:00:00 2001 From: Brendan Kenny Date: Mon, 30 Oct 2017 16:10:55 -0700 Subject: [PATCH] tests(smokehouse): disable multiple shadow root deprecation test --- lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.js | 4 +++- .../test/smokehouse/dobetterweb/dbw-expectations.js | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.js b/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.js index 91b7cbf15cd8..16451fa741d4 100644 --- a/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.js +++ b/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.js @@ -32,7 +32,9 @@ if (location.search === '' || params.has('passiveEvents')) { if (location.search === '' || params.has('deprecations')) { const div = document.createElement('div'); div.createShadowRoot(); - div.createShadowRoot(); // FAIL - multiple shadow v0 roots. + // FAIL(errors-in-console) - multiple shadow v0 roots. + // TODO: disabled until m64 is stable (when moved from deprecation warning to error) + // div.createShadowRoot(); } })(); diff --git a/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js b/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js index 1c998ae3ac78..24f3c04581dd 100644 --- a/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js +++ b/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js @@ -15,6 +15,7 @@ module.exports = [ audits: { 'errors-in-console': { score: false, + // TODO: should be 5 after m64 (see note in dbw_tester.js) rawValue: 4, displayValue: '4', details: { @@ -168,12 +169,12 @@ module.exports = [ score: false, extendedInfo: { value: { - length: 4, + length: 3, }, }, details: { items: { - length: 4, + length: 3, }, }, },