report: animated chevrons #5137
Conversation
| } | ||
| .lh-chevron__line { | ||
| stroke: hsl(216, 5%, 39%); | ||
| transform-origin: 50px 50px; |
There was a problem hiding this comment.
can any of this be set to a variable to scale the chevron or is it all very precarious?
|
Thank you @paulirish 😊🙃🕺💃 |
you can try this out on https://sweltering-ground.surge.sh/cnn.html regarless, in general, i think that with hwi's guidance we won't overdo things. :) |
|
oh not meant as a comment on the awesomeness of the effect all! More that I hope Hwi won't be disappointed with me 🙏 when I'm unable to do the next awesome animation she comes up with in the same amount of time @paulirish did 😆 |
|
oooooooooooh gotcha. :D |
paulirish
changed the base branch from
metricsdisplay-oldrebase
to
metricsdisplay-oldrebase2
|
@patrickhulce had a question for you and then we can land :) |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
paulirish
changed the base branch from
metricsdisplay-oldrebase2
to
oppoAsAnAudit
|
CLAs look good, thanks! |
Thx to @hwikyounglee for putting up with me as I was like "OH HECK NO".
Because I enjoyed making this work. :D
This is dependent on #5136
https://lighthouse-chevrons.now.sh/