report: new styling for audit details #5151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
force-pushed
the
metricsdisplay-oldrebase
branch
from
23f6bef
to
94edb8c
Compare
|
❤️ this. so. much. |
|
Looks great!!! cc: @hwikyounglee |
vinamratasingal-zz
approved these changes
May 7, 2018
|
@hwikyounglee does this work for you? it's this instead of trying expand/collapse within details like these mocks the parent already collapses and the only usecase is: "i only want to see the audit description, but not the details stuff below it." meh. |
|
Yes, having one collapse/expand LGTM. Thanks!!! |
paulirish
force-pushed
the
detailssummaryexperiment
branch
from
82646e4
to
7636cec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example reports:
https://venomous-horse.surge.sh/cnn.html
https://venomous-horse.surge.sh/dbwtester.html
https://venomous-horse.surge.sh/errors.html
https://venomous-horse.surge.sh/example.html
https://venomous-horse.surge.sh/paulirish.html
https://venomous-horse.surge.sh/tinyhouse.html
https://venomous-horse.surge.sh/z.devtools.cnn.html
https://venomous-horse.surge.sh/z.devtools.dbwtester.html
https://venomous-horse.surge.sh/z.devtools.errors.html
https://venomous-horse.surge.sh/z.devtools.example.html
https://venomous-horse.surge.sh/z.devtools.paulirish.html
https://venomous-horse.surge.sh/z.devtools.tinyhouse.html