From cbd0076eb299fa315c4de35b1a86e9c1fe5510a4 Mon Sep 17 00:00:00 2001 From: Paul Irish Date: Sun, 24 Mar 2019 13:48:11 -0700 Subject: [PATCH] docs(url-shim): add comment about public suffix lst --- lighthouse-core/lib/url-shim.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lighthouse-core/lib/url-shim.js b/lighthouse-core/lib/url-shim.js index a275bd88aca6..52691ef4bb2f 100644 --- a/lighthouse-core/lib/url-shim.js +++ b/lighthouse-core/lib/url-shim.js @@ -17,8 +17,9 @@ const Util = require('../report/html/renderer/util.js'); const URL = /** @type {!Window["URL"]} */ (typeof self !== 'undefined' && self.URL) || require('url').URL; -// 25 most used tld plus one domains from http archive. +// 25 most used tld plus one domains (aka public suffixes) from http archive. // @see https://github.com/GoogleChrome/lighthouse/pull/5065#discussion_r191926212 +// The canonical list is https://publicsuffix.org/learn/ but we're only using subset to conserve bytes const listOfTlds = [ 'com', 'co', 'gov', 'edu', 'ac', 'org', 'go', 'gob', 'or', 'net', 'in', 'ne', 'nic', 'gouv', 'web', 'spb', 'blog', 'jus', 'kiev', 'mil', 'wi', 'qc', 'ca', 'bel', 'on',