From 27f5d87205e852d5b98cd7bb10304800a96c0fe6 Mon Sep 17 00:00:00 2001
From: Barry Pollard <barrypollard@google.com>
Date: Tue, 14 May 2024 08:41:18 -0700
Subject: [PATCH] Only apply Firefox workarounds in GitHub Actions (#481)

* Only apply Firefox workarounds in GitHub Actions

* Fix test

* Add override console logging
---
 test/e2e/onFCP-test.js |  1 +
 test/e2e/onLCP-test.js | 11 ++++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/test/e2e/onFCP-test.js b/test/e2e/onFCP-test.js
index 67ade203..ce0de79c 100644
--- a/test/e2e/onFCP-test.js
+++ b/test/e2e/onFCP-test.js
@@ -26,6 +26,7 @@ import {stubVisibilityChange} from '../utils/stubVisibilityChange.js';
 const originalStrictEqual = assert.strictEqual;
 assert.strictEqual = function (actual, expected, message) {
   if (
+    process.env.GITHUB_ACTIONS &&
     browser.capabilities.browserName === 'firefox' &&
     (expected === 'good' || expected === 'needs-improvement') &&
     actual !== expected
diff --git a/test/e2e/onLCP-test.js b/test/e2e/onLCP-test.js
index a501d17f..4b02bc7e 100644
--- a/test/e2e/onLCP-test.js
+++ b/test/e2e/onLCP-test.js
@@ -27,6 +27,7 @@ import {stubVisibilityChange} from '../utils/stubVisibilityChange.js';
 const originalStrictEqual = assert.strictEqual;
 assert.strictEqual = function (actual, expected, message) {
   if (
+    process.env.GITHUB_ACTIONS &&
     browser.capabilities.browserName === 'firefox' &&
     (expected === 'good' || expected === 'needs-improvement') &&
     actual !== expected
@@ -717,7 +718,15 @@ const assertFullReportsAreCorrect = (beacons) => {
 
   // Temp fix to address Firefox flakiness.
   // See https://github.com/GoogleChrome/web-vitals/issues/472
-  if (browser.capabilities.browserName !== 'firefox') {
+  if (
+    process.env.GITHUB_ACTIONS &&
+    browser.capabilities.browserName === 'firefox' &&
+    lcp1.value >= 500
+  ) {
+    console.log(
+      `Override assert for Firefox (actual: ${lcp1.value}, expected: < 500)`,
+    );
+  } else {
     assert(lcp1.value < 500); // Less than the image load delay.
   }
   assert(lcp1.id.match(/^v4-\d+-\d+$/));