Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is CLS actually DCLS? #29

Closed
wildlyinaccurate opened this issue May 9, 2020 · 3 comments · Fixed by #84
Closed

Is CLS actually DCLS? #29

wildlyinaccurate opened this issue May 9, 2020 · 3 comments · Fixed by #84
Assignees
@philipwalton

Comments

@wildlyinaccurate
Copy link

Judging by the implementation, it looks like the "CLS" that web-vitals reports is actually DCLS. Is that right?
@philipwalton
Copy link
Member

Yes, we often use these terms interchangeably, but it's probably worth clarifying in the README that this library does not track layout shifts in iframes.

@philipwalton philipwalton self-assigned this May 10, 2020
@jonathan-fielding jonathan-fielding mentioned this issue May 10, 2020
Closed
@wildlyinaccurate
Copy link
Author

Thanks for clarifying @philipwalton!

@philipwalton
Copy link
Member

I'm going to re-open this as a reminder to update the documentation with clarification as well.

@philipwalton philipwalton reopened this May 10, 2020
@nicjansma nicjansma mentioned this issue Oct 5, 2020
Open
@philipwalton philipwalton mentioned this issue Nov 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipwalton philipwalton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release v1 GoogleChrome/web-vitals
2 participants
@philipwalton @wildlyinaccurate