Move from redis to valkey #843
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our code uses an Cache interface so we just need to implement another implementation of the cache interface for valkey.
jcscottiii
commented
Oct 29, 2024
| # limitations under the License. | ||
|
|
||
| resource "google_network_connectivity_service_connection_policy" "valkey_policy" { | ||
| provider = google-beta |
There was a problem hiding this comment.
I don't want to use the google-beta provider. We can keep this PR around until
- google_network_connectivity_service_connection_policy and google_memorystore_instance move to the stable provider, or
- We absolutely must move to valkey.
There was a problem hiding this comment.
This has now moved from BETA to GA. Check the release notes in this PR: #909
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code uses an Cache interface so we just need to implement another implementation of the cache interface for valkey.
Most of the work is renaming everything from redis to valkey.
The tests that use an actual instance in lib/valkeycache/cache_test.go needed no modifications besides renaming.
With this, we can use the latest version of valkey: 8.0. Whereas we were stuck on 7.2 beforehand.
One thing that is notable, the valkey client uses strings and []byte. We tend to like []byte instead. So what I did was restrict this implementation to []byte values.