Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbox-build: broadcastUpdate channelName #1334

Closed
mischnic opened this issue Feb 27, 2018 · 1 comment
Closed

workbox-build: broadcastUpdate channelName #1334

mischnic opened this issue Feb 27, 2018 · 1 comment
Assignees
Milestone

Comments

@mischnic
Copy link

mischnic commented Feb 27, 2018

Again broadcastUpdate with workbox-build@3.0.0-beta.1:

workbox-build wants this:

"options": {
  "broadcastUpdate": {
    "channelName": "my-update-channel"
  }
}

(resulting in new workbox.broadcastUpdate.Plugin({"channelName":"my-update-channel"}))

but it should be:

"options": {
  "broadcastUpdate": "my-update-channel"
}

(for new workbox.broadcastUpdate.Plugin("my-update-channel"), which actually works)

Without channelName, it doesn't get accepted:

Service worker generation failed: ValidationError: child "runtimeCaching" fails because ["runtimeCaching" at position 1 fails because [child "options" fails because [child "broadcastUpdate" fails because ["broadcastUpdate" must be an object]]]]

There is no {channelName: ...} in the test either:

plugins: [
new workbox.broadcastUpdate.Plugin('bcu-integration-test'),
],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants