Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to use workbox.googleAnalytics in workbox-cli #1568

Closed
connorjclark opened this issue Jul 6, 2018 · 1 comment
Closed

Option to use workbox.googleAnalytics in workbox-cli #1568

connorjclark opened this issue Jul 6, 2018 · 1 comment
Labels
Feature Request workbox-build workbox-cli workbox-google-analytics

Comments

@connorjclark
Copy link

connorjclark commented Jul 6, 2018 •
edited
Loading

Library Affected:
workbox-cli

For now, I think I could just tack onto the generated sw.js, but it would be nice to have this case handled via the CLI.
@jeffposnick
Copy link
Contributor

(Presumably, if we went ahead with this, it would be an option added to the underlying workbox-build.generateSW() method, which is what the workbox-cli calls under the hood.)

@jeffposnick jeffposnick mentioned this issue Aug 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request workbox-build workbox-cli workbox-google-analytics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffposnick @connorjclark