Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registerQuotaErrorCallback is not public in workbox.core #1616

Closed
Tronil opened this issue Aug 30, 2018 · 1 comment
Closed

registerQuotaErrorCallback is not public in workbox.core #1616

Tronil opened this issue Aug 30, 2018 · 1 comment
Assignees
@jeffposnick
Labels
workbox-core

Comments

@Tronil
Copy link

Tronil commented Aug 30, 2018

Library Affected:
workbox-core

Browser & Platform:
all browsers

Issue or Feature Request Description:
According to the docs (https://developers.google.com/web/tools/workbox/reference-docs/latest/workbox.core) registerQuotaErrorCallback should be (a public) part of workbox.core, but it is actually hidden under workbox.core._private (at least for v3.4.1). This makes it a bit hard to use as part of custom cache handling.
@jeffposnick jeffposnick self-assigned this Sep 5, 2018
@jeffposnick
Copy link
Contributor

Sorry about that—it's an oversight that we'll correct in an upcoming release.

@jeffposnick jeffposnick mentioned this issue Sep 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffposnick jeffposnick

Labels
workbox-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffposnick @Tronil