Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing info in the doc's #1670

Closed
ghost opened this issue Sep 29, 2018 · 1 comment
Closed

Missing info in the doc's #1670

ghost opened this issue Sep 29, 2018 · 1 comment
Labels
Documentation Related to our docs. Good First Issue This would be an ideal issue for a new contributor to take on.

Comments

@ghost
Copy link

ghost commented Sep 29, 2018 •
edited by ghost
Loading

Hi,

I am trying to update workbox from 3.4.0 to the latest version 3.6.2

I am reading the https://github.com/GoogleChrome/workbox/releases

The workbox.navigationPreload.disable() is not mentioned in the doc's, see webpage: https://developers.google.com/web/tools/workbox/modules/workbox-navigation-preload#basic_usage
@ghost ghost changed the title Upgrade help - releases info seems incomplete Missing info in the doc's Oct 3, 2018
@jeffposnick jeffposnick added the Documentation Related to our docs. label Oct 4, 2018
@jadjoubran jadjoubran added the Good First Issue This would be an ideal issue for a new contributor to take on. label Nov 26, 2018
@jeffposnick
Copy link
Contributor

It's documented at https://developers.google.com/web/tools/workbox/reference-docs/latest/workbox.navigationPreload#.disable

We don't specifically call out each method that's exposed in the API in that "modules" section of the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Related to our docs. Good First Issue This would be an ideal issue for a new contributor to take on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffposnick @jadjoubran