webpackCompilationPlugins doesn't seem to work

[gabiseabra]

Library Affected:
workbox-webpack-plugin@5.0.0

Browser & Platform:
all browsers

Issue or Feature Request Description:

webpackCompilationPlugins doesn't apply webpack.DefinePlugin and webpack.EnvironmentPlugin to the output bundle.

The following does not replace __REVISION__ in sw.js:

new InjectManifest({
  swSrc: './src/sw/index.js',
  swDest: 'sw.js',
  webpackCompilationPlugins: [
    new webpack.DefinePlugin({
      __REVISION__: JSON.stringify(process.env.COMMIT_SHA1)
    })
  ]
})

[jeffposnick]

Thanks for reporting; I'll take a look.

[jeffposnick]

Sorry that there's no progress to report; based on some local debugging, I can see that DefinePlugin does get added to the childCompilation that workbox-webpack-plugin creates, and I can see it being called during that compilation, but it doesn't appear to have the intended effect.

webpack/webpack#2978 and webpack/webpack#9240 seem related.