Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack v5 compatibility #2630

Closed
chenxsan opened this issue Sep 13, 2020 · 4 comments · Fixed by #2641
Closed

webpack v5 compatibility #2630

chenxsan opened this issue Sep 13, 2020 · 4 comments · Fixed by #2641
Assignees
Milestone

Comments

@chenxsan
Copy link

Library Affected:

  • workbox-webpack-plugin

Browser & Platform:

None

Issue or Feature Request Description:

webpack 5 exposes webpack-sources via webpack.sources, and it's advised to use it instead of require('webpack-sources'), if you agree to do it, I can submit a pull request.

@jeffposnick
Copy link
Contributor

There's a number of non-trivial changes that are needed for webpack v5 compatibility. (C.f. webpack/webpack#11425)

I'm working on implemented all of those changes in the Workbox v6 branch, hopefully in time for the next Workbox pre-release.

@jeffposnick jeffposnick self-assigned this Sep 14, 2020
@jeffposnick jeffposnick changed the title Use require('webpack').sources when possible webpack v5 compatibility Sep 14, 2020
@jeffposnick jeffposnick added this to the v6 milestone Sep 14, 2020
@chaffeqa
Copy link

great to hear! we just moved to webpack 5 and had to remove workbox since it was causing the build to error out.

@chaffeqa
Copy link

the WP5 branch is looking really good! would love to give it a test drive for you!

@jeffposnick
Copy link
Contributor

This is now live as part of the v6.0.0-alpha.3 release: https://github.com/GoogleChrome/workbox/releases/tag/v6.0.0-alpha.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants