Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export all public types directly from workbox-window #2770

Closed
StephanBijzitter opened this issue Mar 7, 2021 · 4 comments · Fixed by #2919
Closed

Export all public types directly from workbox-window #2770

StephanBijzitter opened this issue Mar 7, 2021 · 4 comments · Fixed by #2919
Labels
Feature Request TypeScript Issues related to our TypeScript annotations. workbox-window

Comments

@StephanBijzitter
Copy link
Contributor

As a follow-up on #2255

Library Affected:
workbox-window.

Browser & Platform:
TypeScript

Issue or Feature Request Description:
While a lot of the types can currently be imported, they do use the source filepaths, which could break at any point as SemVer does not (and should not) handle things like that.

So this, while currently valid, is prone to break:

import {WorkboxMessageEvent} from 'workbox-window/src/utils/WorkboxEvent';

The pull request above allows us to import types for workbox-core directly, but sadly this is not the case for workbox-window.

@jeffposnick
Copy link
Contributor

Sounds reasonable!

Feel free to file a PR to accomplish this if you're comfortable doing so—otherwise, someone from the core team will pick it up.

@jeffposnick jeffposnick added Feature Request Good First Issue This would be an ideal issue for a new contributor to take on. TypeScript Issues related to our TypeScript annotations. workbox-window labels Mar 9, 2021
@sahilcode17
Copy link

Hi I would like to contribute to this issue

@jeffposnick
Copy link
Contributor

Thanks! I think the PR at #2919 already addresses it, though.

@jeffposnick jeffposnick removed the Good First Issue This would be an ideal issue for a new contributor to take on. label Aug 18, 2021
@jeffposnick
Copy link
Contributor

This is now live in https://github.com/GoogleChrome/workbox/releases/tag/v6.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request TypeScript Issues related to our TypeScript annotations. workbox-window
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants