Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workbox-build] Uses old deprecated @hapi/joi #2806

Closed
KevinGruber opened this issue Apr 7, 2021 · 2 comments · Fixed by #2867
Closed

[workbox-build] Uses old deprecated @hapi/joi #2806

KevinGruber opened this issue Apr 7, 2021 · 2 comments · Fixed by #2867

Comments

@KevinGruber
Copy link

Welcome! Please use this template for reporting bugs or requesting features. For questions about using Workbox, the best place to ask is Stack Overflow, tagged with [workbox]: https://stackoverflow.com/questions/ask?tags=workbox

Library Affected:
workbox-build, workbox-webpack-plugin

Browser & Platform:
Webpack

Issue or Feature Request Description:
workbox-build is currently using a dep of @hapi/joi which is deprecated and just joi should be used now. Because it still uses @hapi/joi in version 16. which is also old it has a dep to topo 3.x which is incompatible with the new 5.x version. Because of structuring of my packages it is now installing the wrong topo into my project. Would be cool to switch to the "real" dep.*

When reporting bugs, please include relevant JavaScript Console logs and links to public URLs at which the issue could be reproduced.

@jeffposnick
Copy link
Contributor

jeffposnick commented Apr 7, 2021

Apologies for the inconvenience that this might be causing.

We're in the midst of rewriting workbox-build in TypeScript, and as part of that conversion, we'll be moving from @hapi/joi to auto-generated validation logic based on the TypeScript definitions.

Once that's complete, this should no longer be an issue. Thanks for your patience in the meantime.

@KevinGruber
Copy link
Author

Hi :-)

Thanks for answering and awesome to hear.
I am looking forward to that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants