Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate:sw wizard Should ignore hidden directories when presenting folder to use as root #549

Closed
jpmedley opened this issue May 16, 2017 · 1 comment
Closed

generate:sw wizard Should ignore hidden directories when presenting folder to use as root #549

jpmedley opened this issue May 16, 2017 · 1 comment

Comments

@jpmedley
Copy link
Contributor

Library Affected:
workbox-cli

My test directory had two folders, app/ and .git/. It doesn't seem like any hidden folder would ever be the root of a site's content. If I'm right, then workbox-cli shouldn't offer hidden folders as an option.
@addyosmani addyosmani added the P1 label Jun 1, 2017
@addyosmani
Copy link
Member

Marking as P1. We'll need to verify this is indeed still the current behavior, but I agree that user expectation would probably not be to include hidden directories as a default.

@gauntface gauntface mentioned this issue Jun 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@addyosmani @jpmedley