Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup breaks with some css resets #568

Open
RJWadley opened this issue Sep 21, 2022 · 2 comments
Open

Popup breaks with some css resets #568

RJWadley opened this issue Sep 21, 2022 · 2 comments

Comments

@RJWadley
Copy link

RJWadley commented Sep 21, 2022

The visbug popup seems to depend on some styles that can get reverted with some newer css resets, causing it to appear beneath the page content, full width, and in the document flow.

Steps to reproduce:

  1. Create a react app that uses https://github.com/elad2412/the-new-css-reset
  2. Open visbug
@argyleink
Copy link
Member

confirmed here https://stackblitz.com/edit/react-ts-bmgkzm?file=style.css,new-reset.css

curious that selector has higher specificity than a constructed stylesheet in a shadow :host. will investigate. thanks for reporting!

@argyleink
Copy link
Member

after some research, it appears that my :host styles need an !important in order to win over a style like this.

ToDo:

  • all light dom shadow styles should use !important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants