Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create PC/SC permission prompts on Login Screen #1170

Open
emaxx-google opened this issue May 21, 2024 · 1 comment
Open

Don't create PC/SC permission prompts on Login Screen #1170

emaxx-google opened this issue May 21, 2024 · 1 comment

Comments

@emaxx-google
Copy link
Collaborator

emaxx-google commented May 21, 2024

Permission prompts are useless on ChromeOS Login Screen because the user (intentionally) doesn't normally see them. Even if they saw them, ChromeOS wipes out all storage every time the Login Screen is loaded, also login-screen extensions are shut down when there's an active user session.

The only reason we create them today is because this allowed the code to be simpler and consistent with the in-session behavior.

@emaxx-google
Copy link
Collaborator Author

One thing to keep in mind: when changing the code to not show the dialogs, we should still not bail out immediately like in the "user canceled the dialog branch". Instead we should "hang" the requests indefinitely, because it's possible that after some time admin policy arrives that force-allows a client extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant