Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: chromium-bidi auto-attaches to custom CDP sessions created over bidi+ #2420

Closed
OrKoN opened this issue Jul 17, 2024 · 0 comments
Closed

Bug: chromium-bidi auto-attaches to custom CDP sessions created over bidi+ #2420

OrKoN opened this issue Jul 17, 2024 · 0 comments

Comments

@OrKoN
Copy link
Collaborator

OrKoN commented Jul 17, 2024

If the client sends a command over bidi+ to attach to the specific target via Target.attachToTarget, the mapper would unnecessarily auto-attach to the session and enable CDP domains.

Expected result: mapper should not auto-attach (or detach from) to such sessions.

Related to puppeteer/puppeteer#12768

cc @sadym-chromium @Lightning00Blade
@OrKoN OrKoN mentioned this issue Jul 17, 2024
Merged
OrKoN added a commit that referenced this issue Jul 22, 2024
@OrKoN
fix: only auto-attach to a target once (#2421)
7118b96 
This can be a workaround for
#2420
@OrKoN OrKoN closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OrKoN