Fix issue where toolbox successResponses is stripped (#265)

* Fix issue where toolbox successResponses is stripped Fixed a bug wth successResponses similar to #228 * fixed lint error * fixed incorrect if block
GoogleChromeLabs · Mar 22, 2017 · ac7da0e · ac7da0e
1 parent ad24803
commit ac7da0e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/sw-precache.js b/lib/sw-precache.js
@@ -117,6 +117,10 @@ function stringifyToolboxOptions(options) {
   if (options.origin instanceof RegExp) {
     str = str.replace(/("origin":)\{\}/, '$1' + options.origin);
   }
+  if (options.successResponses instanceof RegExp) {
+    str = str.replace(/("successResponses":)\{\}/,
+      '$1' + options.successResponses);
+  }
   return str;
 }
 

diff --git a/test/test.js b/test/test.js
@@ -474,6 +474,17 @@ describe('generateRuntimeCaching', function() {
     }]);
     assert.equal(code, '\ntoolbox.router.get("/*", toolbox.testHandler, {"origin":"http://www.example.com"});');
   });
+
+  it('should handle successResponses regex', function() {
+    var code = generateRuntimeCaching([{
+      urlPattern: '/*',
+      handler: 'testHandler',
+      options: {
+        successResponses: /^200$/
+      }
+    }]);
+    assert.equal(code, '\ntoolbox.router.get("/*", toolbox.testHandler, {"successResponses":/^200$/});');
+  });
 });
 
 describe('cleanResponse', function() {