Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanner to Source basic impl #1707

Merged
merged 13 commits into from
Jul 25, 2024
Merged

Conversation

aksharauke
Copy link
Contributor

@aksharauke aksharauke commented Jul 2, 2024

The template does the basic reverse replication of multiple shards.
Follow-up PRs to include:

  1. More UT
  2. More IT
  3. DLQ handling
  4. Session file absence
  5. Custom transform porting

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 34.78261% with 660 lines in your changes missing coverage. Please review.

Project coverage is 42.14%. Comparing base (dd00fe4) to head (565eee6).
Report is 120 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1707      +/-   ##
============================================
+ Coverage     41.25%   42.14%   +0.89%     
- Complexity     2939     3276     +337     
============================================
  Files           771      808      +37     
  Lines         45114    47256    +2142     
  Branches       4818     5044     +226     
============================================
+ Hits          18612    19918    +1306     
- Misses        24935    25695     +760     
- Partials       1567     1643      +76     
Components Coverage Δ
spanner-templates 63.67% <ø> (+2.44%) ⬆️
spanner-import-export 64.38% <ø> (-0.05%) ⬇️
spanner-live-forward-migration 74.97% <ø> (+0.93%) ⬆️
spanner-live-reverse-replication 51.84% <ø> (+1.41%) ⬆️
spanner-bulk-migration 82.79% <ø> (+2.22%) ⬆️
Files Coverage Δ
...eport/v2/templates/transforms/FilterRecordsFn.java 100.00% <100.00%> (ø)
...t/v2/templates/transforms/PreprocessRecordsFn.java 100.00% <100.00%> (ø)
...s/changestream/TrimmedShardedDataChangeRecord.java 65.95% <65.95%> (ø)
...t/v2/templates/utils/ShardingLogicImplFetcher.java 58.69% <58.69%> (ø)
...es/changestream/DataChangeRecordTypeConvertor.java 60.71% <60.71%> (ø)
...eleport/v2/templates/utils/ShardIdFetcherImpl.java 40.54% <40.54%> (ø)
.../cloud/teleport/v2/templates/utils/SpannerDao.java 0.00% <0.00%> (ø)
...eport/v2/templates/utils/InputRecordProcessor.java 0.00% <0.00%> (ø)
...loud/teleport/v2/templates/utils/DMLGenerator.java 78.68% <78.68%> (ø)
...le/cloud/teleport/v2/templates/utils/MySqlDao.java 0.00% <0.00%> (ø)
... and 4 more

... and 56 files with indirect coverage changes

Copy link
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the main classes and left comments. Will review tests now.

Copy link
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@aksharauke aksharauke merged commit 72daacc into GoogleCloudPlatform:main Jul 25, 2024
13 checks passed
@aksharauke aksharauke deleted the rr branch July 26, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants