-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanner to Source basic impl #1707
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1707 +/- ##
============================================
+ Coverage 41.25% 42.14% +0.89%
- Complexity 2939 3276 +337
============================================
Files 771 808 +37
Lines 45114 47256 +2142
Branches 4818 5044 +226
============================================
+ Hits 18612 19918 +1306
- Misses 24935 25695 +760
- Partials 1567 1643 +76
|
.../com/google/cloud/teleport/v2/templates/changestream/DataChangeRecordConvertorException.java
Outdated
Show resolved
Hide resolved
.../com/google/cloud/teleport/v2/templates/changestream/DataChangeRecordConvertorException.java
Show resolved
Hide resolved
...sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/changestream/package-info.java
Show resolved
Hide resolved
...ourcedb/src/main/java/com/google/cloud/teleport/v2/templates/transforms/AssignShardIdFn.java
Show resolved
Hide resolved
...nner-to-sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/SpannerToSourceDb.java
Show resolved
Hide resolved
.../java/com/google/cloud/teleport/v2/templates/changestream/DataChangeRecordTypeConvertor.java
Show resolved
Hide resolved
...sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/transforms/SourceWriterFn.java
Show resolved
Hide resolved
...sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/transforms/SourceWriterFn.java
Show resolved
Hide resolved
...sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/transforms/SourceWriterFn.java
Show resolved
Hide resolved
...sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/transforms/SourceWriterFn.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the main classes and left comments. Will review tests now.
...nner-to-sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/SpannerToSourceDb.java
Outdated
Show resolved
Hide resolved
...nner-to-sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/SpannerToSourceDb.java
Show resolved
Hide resolved
...nner-to-sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/SpannerToSourceDb.java
Show resolved
Hide resolved
.../java/com/google/cloud/teleport/v2/templates/changestream/DataChangeRecordTypeConvertor.java
Outdated
Show resolved
Hide resolved
v2/spanner-to-sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/package-info.java
Outdated
Show resolved
Hide resolved
...sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/transforms/SourceWriterFn.java
Show resolved
Hide resolved
...sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/transforms/SourceWriterFn.java
Show resolved
Hide resolved
...cedb/src/main/java/com/google/cloud/teleport/v2/templates/utils/InformationSchemaReader.java
Outdated
Show resolved
Hide resolved
...-sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/utils/ShadowTableCreator.java
Show resolved
Hide resolved
...-sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/utils/ShardIdFetcherImpl.java
Show resolved
Hide resolved
...edb/src/test/java/com/google/cloud/teleport/v2/templates/transforms/FilterRecordsFnTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
The template does the basic reverse replication of multiple shards.
Follow-up PRs to include: