-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adding file for load testing data generation #1733
docs: adding file for load testing data generation #1733
Conversation
adding file for load testing adding file for load testing
2af92d8
to
8fa6ed0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1733 +/- ##
============================================
+ Coverage 42.66% 42.86% +0.20%
- Complexity 3382 3702 +320
============================================
Files 815 815
Lines 47693 47703 +10
Branches 5109 5110 +1
============================================
+ Hits 20350 20450 +100
+ Misses 25687 25592 -95
- Partials 1656 1661 +5
|
...tream-to-spanner/src/test/java/com/google/cloud/teleport/v2/templates/README_Load_Testing.md
Outdated
Show resolved
Hide resolved
...tream-to-spanner/src/test/resources/DataStreamToSpannerLoadTesting/datagenerator-schema.json
Outdated
Show resolved
Hide resolved
...tream-to-spanner/src/test/java/com/google/cloud/teleport/v2/templates/README_Load_Testing.md
Show resolved
Hide resolved
...tream-to-spanner/src/test/java/com/google/cloud/teleport/v2/templates/README_Load_Testing.md
Show resolved
Hide resolved
...tream-to-spanner/src/test/java/com/google/cloud/teleport/v2/templates/README_Load_Testing.md
Show resolved
Hide resolved
...tream-to-spanner/src/test/java/com/google/cloud/teleport/v2/templates/README_Load_Testing.md
Show resolved
Hide resolved
...tream-to-spanner/src/test/java/com/google/cloud/teleport/v2/templates/README_Load_Testing.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but just want to point out that there is already a Load Testing framework within this repo that can be leveraged, if desired.
For example,
https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/main/v2/jdbc-to-googlecloud/src/test/java/com/google/cloud/teleport/v2/templates/JdbcToBigQueryLT.java
which runs the StreamingDataGenerator template to stream data to Pub/Sub, and then (in this case) runs the PubSubToBigQuery template to stream data from Pub/Sub to BigQuery either after accumulating a backlog (testBacklog10gb) or simply running for an hour (testSteadyState1hr) in parallel with the StreamingDataGenerator template.
This framework also automatically generates a job metrics table and writes to BigQuery.
A separate load testing workflow already exists for Spanner: https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/main/.github/workflows/spanner-load-tests.yml (runs daily at 2am)
and could be modified (or another created) for your specific needs.
Thankyou @Polber, we will be leveraging the load testing framework but we want to generate the data for the load tests ahead of time. Also we have sometimes need to test new use cases for customers and if Spanner Migration Tool works for them. We are documenting this method here so that others can leverage the technique as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.