Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings for excess tables #1900

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

Deep1998
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 50.00%. Comparing base (bee9d58) to head (515e6b4).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...loud/teleport/v2/templates/PipelineController.java 0.00% 29 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1900      +/-   ##
============================================
+ Coverage     43.99%   50.00%   +6.01%     
+ Complexity     3457     1182    -2275     
============================================
  Files           827      368     -459     
  Lines         49041    20028   -29013     
  Branches       5141     2014    -3127     
============================================
- Hits          21576    10016   -11560     
+ Misses        25816     9345   -16471     
+ Partials       1649      667     -982     
Components Coverage Δ
spanner-templates 63.25% <0.00%> (-0.33%) ⬇️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 74.83% <ø> (-0.41%) ⬇️
spanner-live-reverse-replication 68.55% <ø> (+0.14%) ⬆️
spanner-bulk-migration 83.87% <0.00%> (-0.43%) ⬇️
Files with missing lines Coverage Δ
...loud/teleport/v2/templates/PipelineController.java 16.57% <0.00%> (-2.90%) ⬇️

... and 490 files with indirect coverage changes

Copy link
Contributor

@bharadwaj-aditya bharadwaj-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deep1998 Deep1998 merged commit 97e43ce into GoogleCloudPlatform:main Oct 3, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants