Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Certs for Mutation/Validatiion Webhooks #169

Closed
markmandel opened this issue Apr 8, 2018 · 0 comments
Closed

Generate Certs for Mutation/Validatiion Webhooks #169

markmandel opened this issue Apr 8, 2018 · 0 comments
Labels
area/security Issues pertaining to security good first issue These are great first issues. If you are looking for a place to start, start here! kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Milestone

Comments

@markmandel
Copy link
Member

Now that we have #101 (Helm) we can use it to generate the cert for the validation and mutation webhook at installation time.

Design

Looks like it should be relatively straight forward, as there is a genSignedCert function built into helm. See examples below.

We will need to change the controller so that it pulls the cert that it uses from a generated Secret.

This should be relatively straightforward as it already reads the certs a file , we'll just need to not add them in the Dockerfile and make sure to mount the Secret in the controller deployment

Research

https://github.com/lachie83/internallb-webhook-admission-controller/blob/master/charts/internallb-webhook-admission-controller/templates/admissionregistration.yaml
https://github.com/kubernetes/helm/blob/master/docs/charts_tips_and_tricks.md
http://masterminds.github.io/sprig/crypto.html

@markmandel markmandel added kind/feature New features for Agones kind/design Proposal discussing new features / fixes and how they should be implemented area/security Issues pertaining to security good first issue These are great first issues. If you are looking for a place to start, start here! labels Apr 8, 2018
@markmandel markmandel added this to the 0.2 milestone May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Issues pertaining to security good first issue These are great first issues. If you are looking for a place to start, start here! kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Projects
None yet
Development

No branches or pull requests

1 participant