SDK GameServer() function for retrieving backing GameServer configuration
#288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
kind/feature
|
Build Failed 😱 Build Id: 5ead8341-91f0-40a0-a91c-8922aafa312c Build Logs |
markmandel
force-pushed
the
feature/sdk-gameserver-data
branch
from
563c592
to
5647b40
Compare
|
Build Succeeded 👏 Build Id: 8990a35c-cec2-46c8-98b6-b453df31b649 The following development artifacts have been built, and will exist for the next 30 days:
|
cyriltovena
approved these changes
Jul 16, 2018
| ```bash | ||
| $ curl -H "Content-Type: application/json" -X GET http://localhost:59358/gameserver | ||
| ``` |
There was a problem hiding this comment.
Should we show an expected response or link to the model?
There was a problem hiding this comment.
Good call. Added expected response.
pkg/gameservers/localsdk_test.go
Outdated
|
|
||
| gs, err := l.GetGameServer(ctx, e) | ||
| assert.Nil(t, err) | ||
| assert.Equal(t, "local", gs.GetObjectMeta().Name) |
There was a problem hiding this comment.
You can equal a full object with testity.
| @@ -38,7 +38,7 @@ metadata: | |||
| rules: | |||
| - apiGroups: ["stable.agones.dev"] | |||
| resources: ["gameservers"] | |||
| verbs: ["get", "update"] | |||
| verbs: ["get", "list", "update"] | |||
There was a problem hiding this comment.
Do we still need get since you have a cache sdk side with the list ?
There was a problem hiding this comment.
Nicely spotted! No we do not. Removed get.
| @@ -98,8 +115,125 @@ | |||
| } | |||
| }, | |||
| "definitions": { | |||
| "GameServerObjectMeta": { | |||
| "type": "object", | |||
…ration. Extended the gRPC SDK to include a `GameServer()` function for both Go, C++ and REST by extending the backing `sdk.proto` and implementing the functionality in the sdk sidecar. This is the start of work needed for googleforgames#277.
markmandel
force-pushed
the
feature/sdk-gameserver-data
branch
from
5647b40
to
f25990b
Compare
|
Build Succeeded 👏 Build Id: 4961d40b-b6a6-4038-b43b-ad2aaaefa435 The following development artifacts have been built, and will exist for the next 30 days:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the gRPC SDK to include a
GameServer()function for both Go, C++and REST by extending the backing
sdk.protoand implementing the functionalityin the sdk sidecar.
This is the start of work needed for #277.