Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development tools to enable pprof #422

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Development tools to enable pprof #422

merged 1 commit into from
Nov 16, 2018

Conversation

markmandel
Copy link
Member

Tools for building a controller with pprof enabed, and Make targets for accessing the http pprof endpoint while it is running on a Kubernetes cluster, with accompanying documentation.

This will help in diagnosing #414

@markmandel markmandel added kind/feature New features for Agones area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Nov 15, 2018
@markmandel markmandel added this to the 0.6.0 milestone Nov 15, 2018
@markmandel
Copy link
Member Author

@enocom does this look a good way to do this? Is there a better way?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a06820c1-3b2c-45b7-927f-4f89d19f6e9d

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/422/head:pr_422 && git checkout pr_422
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.6.0-9c1c9da

@markmandel
Development tools to enable pprof
5c8bd63 
Tools for building a controller with pprof enabed, and Make targets
for accessing the http pprof endpoint while it is running on a Kubernetes
cluster, with accompanying documentation.

This will help in diagnosing googleforgames#414
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c61f13a0-30f3-4336-9320-d8225ababba8

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/422/head:pr_422 && git checkout pr_422
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.6.0-5c8bd63

@markmandel markmandel mentioned this pull request Nov 16, 2018
Closed
enocom
enocom reviewed Nov 16, 2018
View reviewed changes
Copy link
Contributor

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Starting a pprof server listening on all interfaces can be a security concern, but provided it's just for development-based debug, I think it should be fine.

@markmandel markmandel merged commit 63cd0a4 into googleforgames:master Nov 16, 2018
@markmandel markmandel deleted the build/pprof branch November 16, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/feature New features for Agones
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @enocom