adding Prometheus+Grafana for metrics and visualizations #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
added
the
feature-freeze-do-not-merge
|
Build Succeeded 👏 Build Id: e318c928-0e09-46a0-bbbe-57e3de11e2d3 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
cyriltovena
force-pushed
the
features/prometheus-grafana
branch
from
7fa3122
to
ad69cbc
Compare
|
Build Succeeded 👏 Build Id: a142b7d5-178b-4407-bc96-f69b7ed10429 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
markmandel
removed
feature-freeze-do-not-merge
|
I think you said you wanted to add something else to this before I review it? Was that right? |
|
No that’s ready, I changed how grafana datasources are provisionned i.e as helm config before it was flaky. I would love feedback on linux !! |
|
I'll take it for a spin tomorrow! |
markmandel
reviewed
Jan 9, 2019
|
Just tested out the installation - and it works perfectly. So awesome 🥇 Let's make the changes we discussed to docs for user installation, and I think we are good to go. |
markmandel
reviewed
Jan 10, 2019
There was a problem hiding this comment.
Forgot to mention that I had to make the changes to linux.mk.
Also attached as a patch, in case that is easier to apply.
linux.mk.patch.txt
|
Build Succeeded 👏 Build Id: 52b2fe79-45e2-4431-bb69-1171f5b50971 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
|
Build Failed 😱 Build Id: 938dc6f7-0f05-4656-b090-552252796a8c Build Logs |
|
Build Succeeded 👏 Build Id: 9d99da36-3aef-4066-b9ea-7b2359dcf949 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
|
suggestion for your grafana PR: can you make "GameServers count per type" stacked by default and fill=10 ? |
cyriltovena
force-pushed
the
features/prometheus-grafana
branch
from
0de07d2
to
f95006d
Compare
|
@markmandel Should be better now ! |
|
Build Succeeded 👏 Build Id: 53a7623f-cf49-46bc-8187-944de0846e37 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
markmandel
reviewed
Jan 13, 2019
cyriltovena
force-pushed
the
features/prometheus-grafana
branch
from
f95006d
to
6dbadc1
Compare
|
Build Succeeded 👏 Build Id: 0aab6d15-fe98-4e06-b74f-5c7424f5fbf8 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
markmandel
added
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Grafana dashboard and Prometheus backend integration for metrics (#144 ).
I'm also including make targets to help users as well as more documentation.
If you want to take it for a spin on kind use:
Then access Grafana dashboards using
make kind-grafana-portforwardand browse at http://127.0.0.1:3000