Add TLS to Fleetautoscaler webhook service #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Succeeded 👏 Build Id: 35a4b69a-0008-4c9e-b562-a6f1eeb921da The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
aLekSer
force-pushed
the
autoscaler-webhook-tls
branch
from
1325e13
to
a200bf9
Compare
|
Build Succeeded 👏 Build Id: eb108893-2319-4275-b6ac-5cca48cd23ec The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
markmandel
reviewed
Jan 9, 2019
aLekSer
force-pushed
the
autoscaler-webhook-tls
branch
from
a200bf9
to
f6e2641
Compare
|
Build Failed 😱 Build Id: 4a3c15ac-4929-4246-858c-a061ce961e99 Build Logs |
aLekSer
force-pushed
the
autoscaler-webhook-tls
branch
from
f6e2641
to
86b1326
Compare
|
Build Succeeded 👏 Build Id: baac87ab-c6e6-412f-974c-69e3a3d7d8ce The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
|
I have tested that I can configure 3 fleetautoscalers for 3 fleets: one which is HTTP, one with rootCA.pem and one with another rootCa2.pem. |
markmandel
added
kind/feature
aLekSer
force-pushed
the
autoscaler-webhook-tls
branch
from
86b1326
to
aee598c
Compare
|
Build Succeeded 👏 Build Id: 945b86d9-4592-4dcd-b186-c606cb205df7 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
|
I just pushed up gcr.io/agones-images/autoscaler-webhook:0.2 - where you going to update the e2e test with the new image? |
aLekSer
force-pushed
the
autoscaler-webhook-tls
branch
from
aee598c
to
4dcbcf1
Compare
|
Build Succeeded 👏 Build Id: f500ce39-bcd8-4423-9a10-ad058bdf9542 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
Add TLS CA Bundle verification if HTTPS scheme is used. Environment variables to configure main scaling parameters. Now both HTTP and HTTPS webhook servers could be used simultaneously in different fleetautoscalers. Add tutorial on using HTTPS webhook fleetautoscaler.
aLekSer
force-pushed
the
autoscaler-webhook-tls
branch
from
4dcbcf1
to
957d9b1
Compare
|
Build Succeeded 👏 Build Id: 1398c507-054c-4a14-9637-b9f2de5d7544 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
|
I have added E2E test for HTTPS webhook autoscaler with creating secret on GKE which contains pre-generated crt and key issued using pre-generated CA certificate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TLS CA Bundle verification if HTTPS scheme is used.
Environment variables were added to configure main scaling parameters of example Fleetautoscaler Webhook Server. Now both HTTP and HTTPS webhook servers could be used simultaneously in different fleetautoscalers for separate fleets.
Provided tutorial on using HTTPS webhook fleetautoscaler.