Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit stress test metrics in Fortio format. #586

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

jkowalski
Copy link
Contributor

@jkowalski jkowalski commented Feb 11, 2019

This addresses the instrumentation aspect of #573 which is emitting performance metrics from E2E tests and saving them to a folder in JSON format compatible with Fortio.

By default stress test results are saved in build/.perf directory.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ffe801c4-bad6-42cc-aea8-48673214b41b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel added kind/feature New features for Agones area/performance Anything to do with Agones being slow, or making it go faster. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Feb 12, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 82d65f19-4ced-46fe-8cd2-9f591cc5c39e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/586/head:pr_586 && git checkout pr_586
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-e417a6b

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fe4f564c-0c88-4116-9fe4-00189b45ffe2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/586/head:pr_586 && git checkout pr_586
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-e68e648

@markmandel
Copy link
Member

Is this on hold until we're happy with #573 ?

@jkowalski
Copy link
Contributor Author

Is this on hold until we're happy with #573 ?

This is a small component of the solution, I'm hoping not a controversial one, unless we don't want to do Fortio at all.

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a small nit - overall looks fine by me. I'll defer approval to @Kuqd who is more on the performance side than I am.

"github.com/sirupsen/logrus"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: blank line.

}

// New setups a testing framework using a kubeconfig path and the game server image to use for testing.
func New(kubeconfig, gsimage string, pullSecret string, stressTestLevel int) (*Framework, error) {
func New(kubeconfig string) (*Framework, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious reason for this - getting too wide?

Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next steps would be to send this to some gcs buckets. This could be useful for our in GKE cluster end-to-end tests suite.

I think this is good to have until we are set on #573 which is in good shape. We've got good options.

@aLekSer
Copy link
Collaborator

aLekSer commented Feb 20, 2019

@jkowalski Possibly we need to add a small description of make stress-test-e2e in a build/README.md file:
https://github.com/GoogleCloudPlatform/agones/blob/4ee2602c77bad8293d5dc8a86486ddd5c74fd844/build/README.md#L41
It is hard to guess the suitable cluster size needed to run test with STRESS_TEST_LEVEL=20
Currently only stress test levels <= 2 can be executed on default gcloud-test-cluster.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 126b816e-0441-4719-9e0d-6666591c00bb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/586/head:pr_586 && git checkout pr_586
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-607ab8f

@markmandel markmandel removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Feb 21, 2019
@markmandel markmandel merged commit 992b1bb into googleforgames:master Feb 21, 2019

e := json.NewEncoder(f)
e.SetIndent("", " ")
e.Encode(rr) //nolint:errcheck
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have error check here?

@markmandel markmandel added this to the 0.9.0 milestone Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Anything to do with Agones being slow, or making it go faster. area/tests Unit tests, e2e tests, anything to make sure things don't break kind/feature New features for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants