-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit stress test metrics in Fortio format. #586
Conversation
Build Failed 😱 Build Id: ffe801c4-bad6-42cc-aea8-48673214b41b To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 82d65f19-4ced-46fe-8cd2-9f591cc5c39e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: fe4f564c-0c88-4116-9fe4-00189b45ffe2 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Is this on hold until we're happy with #573 ? |
This is a small component of the solution, I'm hoping not a controversial one, unless we don't want to do Fortio at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a small nit - overall looks fine by me. I'll defer approval to @Kuqd who is more on the performance side than I am.
"github.com/sirupsen/logrus" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: blank line.
} | ||
|
||
// New setups a testing framework using a kubeconfig path and the game server image to use for testing. | ||
func New(kubeconfig, gsimage string, pullSecret string, stressTestLevel int) (*Framework, error) { | ||
func New(kubeconfig string) (*Framework, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious reason for this - getting too wide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next steps would be to send this to some gcs buckets. This could be useful for our in GKE cluster end-to-end tests suite.
I think this is good to have until we are set on #573 which is in good shape. We've got good options.
@jkowalski Possibly we need to add a small description of |
Build Succeeded 👏 Build Id: 126b816e-0441-4719-9e0d-6666591c00bb The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
||
e := json.NewEncoder(f) | ||
e.SetIndent("", " ") | ||
e.Encode(rr) //nolint:errcheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to have error check here?
This addresses the instrumentation aspect of #573 which is emitting performance metrics from E2E tests and saving them to a folder in JSON format compatible with Fortio.
By default stress test results are saved in
build/.perf
directory.